Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #26869 honor overwritewebroot and PATH_INFO #26882
Fixes #26869: honor overwritewebroot config property and PATH_INFO in request handling so that owncloud can be run under a contextroot such as /owncloud or /cloud
Motivation and Context
How Has This Been Tested?
Please check the description and comments in #26869. I applied these changes to my owncloud 9.1 + nginx 1.10 installation in order to make it work under a contextroot of
As my PHP is rather rusty and I'm not too familiar with how owncloud is tested, I didn't adjust https://github.com/owncloud/core/blob/37177dd54d67443cacc0061c17f95070442b93cf/tests/lib/AppFramework/Http/RequestTest.php though this is definitely necessary as I couldn't spot any tests with a contextroot!
Types of changes
I will send another pull-request with an update to https://doc.owncloud.org/server/9.0/admin_manual/installation/nginx_examples.html#owncloud-in-a-subdir-of-nginx so that other users don't have to read #26869 but can get the necessary information there.
Alexander Heusingfeld seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase.
This PR targetted ownCloud 11 which is postponed to a far distant future.
Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days.
Thanks a lot for your patience