Fix #26869 honor overwritewebroot and PATH_INFO

[aheusingfeld]

Description

Fixes #26869: honor overwritewebroot config property and PATH_INFO in request handling so that owncloud can be run under a contextroot such as /owncloud or /cloud

Related Issue

#26869

Motivation and Context

see description.

How Has This Been Tested?

Please check the description and comments in #26869. I applied these changes to my owncloud 9.1 + nginx 1.10 installation in order to make it work under a contextroot of /cloud -> I tested this change on a production installation.

As my PHP is rather rusty and I'm not too familiar with how owncloud is tested, I didn't adjust https://github.com/owncloud/core/blob/37177dd54d67443cacc0061c17f95070442b93cf/tests/lib/AppFramework/Http/RequestTest.php though this is definitely necessary as I couldn't spot any tests with a contextroot!

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

I will send another pull-request with an update to https://doc.owncloud.org/server/9.0/admin_manual/installation/nginx_examples.html#owncloud-in-a-subdir-of-nginx so that other users don't have to read #26869 but can get the necessary information there.

[mention-bot]

@aheusingfeld, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @tanghus and @bartv2 to be potential reviewers.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Alexander Heusingfeld seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[aheusingfeld]

Hey there, any feedback is highly appreciated.

[PVince81]

@DeepDiver1975 please review, this is very-core stuff

[DeepDiver1975]

What could possible go wrong 😉

[ghost]

What could possible go wrong

It seems the PATH_INFO stuff needs to be handled with care. In NC they have even removed the PATH_INFO stuff in that file: nextcloud/server#984 as it caused constant page refresh like also reported in core: #27053

[PVince81]

@DeepDiver1975 @butonic @phisch @IljaN can we get this in ?

[PVince81]

@DeepDiver1975 @butonic @phisch ping

[DeepDiver1975]

As discussed in #35777 the master branch will from now on hold the ownCloud 10 codebase.

This PR targetted ownCloud 11 which is postponed to a far distant future.

Because of that I'm closing this PR and kindly ask you to re-submit this PR in a few days.

Thanks a lot for your patience