Integration tests fixing alt home #26920

Merged
merged 3 commits into from Jan 11, 2017

Projects

None yet

3 participants

@SergioBertolinSG
Member

Fixing the problems found in #26918

Running tests locally, will add output after they finish.

@SergioBertolinSG SergioBertolinSG added this to the 10.0 milestone Jan 11, 2017
@SergioBertolinSG SergioBertolinSG self-assigned this Jan 11, 2017
@SergioBertolinSG SergioBertolinSG requested a review from PVince81 Jan 11, 2017
@mention-bot

@SergioBertolinSG, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975 and @davitol to be potential reviewers.

+ * @param string $source
+ * @param string $destination
+ */
+ public function userUploadsAFileFromHisHomeTo($user, $source, $destination)
@PVince81
PVince81 Jan 11, 2017 Collaborator

with "home" do you mean local folder on the local machine, not ownCloud home ?
This wording is confusing.

@SergioBertolinSG
SergioBertolinSG Jan 11, 2017 Member

No, I mean owncloud home. User is also an owncloud user.

@PVince81
PVince81 Jan 11, 2017 Collaborator

This scenario as worded is not possible in a regular ownCloud. You can't upload a file from your ownCloud home. You can upload to your ownCloud home.

I think the reason for this is that you're reading the file directly from inside the data folder to test upload ? You should rather read the file from an external folder containing sample files.

@PVince81
PVince81 Jan 11, 2017 Collaborator

Also one problem with reading a file directly from the data folder is that in some cases that file could be encrypted, that could break tests.

@SergioBertolinSG
SergioBertolinSG Jan 11, 2017 Member

OK, then I'll have to change those scenarios.

@SergioBertolinSG
SergioBertolinSG Jan 11, 2017 Member

Moving the file seems more appropiate.

@SergioBertolinSG
SergioBertolinSG Jan 11, 2017 Member

I have changed the federation tests, now that part is not needed.

@PVince81

Looks good except for the wording issue

@SergioBertolinSG
Member

Tests using alt home variable have passed.

SergioBertolinSG added some commits Jan 11, 2017
@SergioBertolinSG SergioBertolinSG Fixed federation tests fb785f2
@SergioBertolinSG SergioBertolinSG Do not take into account testing app in enabled apps scenario
6c2f308
@SergioBertolinSG
Member

Tests have passed locally after last changes.

@PVince81
Collaborator

Thanks, merging then 👍

I'll then rebase the other PR after that.

@PVince81 PVince81 merged commit d8ba9f4 into master Jan 11, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@PVince81 PVince81 deleted the integration-tests-fixing-alt-home branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment