[Stable8.2] autoloader fixup retry #27108

Merged
merged 3 commits into from Feb 8, 2017

Conversation

Projects
None yet
5 participants
@VicDeo
Member

VicDeo commented Feb 7, 2017

Description

Two autoloader-related commits cherry-picked from stable9
ff1271c
and
0bb5ead

Related Issue

owncloud/enterprise#1769

Motivation and Context

Fixes autoloader failure while executing occ script from config directory

How Has This Been Tested?

cd owncloud/config && sudo -uwww-data php ../occ status

Expected

occ status executed

Actual

OCP\AutoloadNotAllowedException is thrown

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

LukasReschke and others added some commits Oct 25, 2015

Remove dead code
Those variables are never written to. Thus this is dead code which should be removed.
[autoloader] Make sure to load construct full paths
This reduces a lot of the autoloader magic and makes sure that we
generate full paths in the autoloader.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 7, 2017

@VicDeo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @DeepDiver1975 and @bartv2 to be potential reviewers.

@VicDeo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @DeepDiver1975 and @bartv2 to be potential reviewers.

@VicDeo VicDeo referenced this pull request Feb 7, 2017

Closed

[Stable8.2] autoloader fixup #27092

3 of 9 tasks complete

@VicDeo VicDeo added the 3 - To Review label Feb 7, 2017

@VicDeo VicDeo added this to the 8.2.11 milestone Feb 7, 2017

@VicDeo VicDeo changed the title from Stable8.2 autoloader retry to [Stable8.2] autoloader fixup retry Feb 7, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Feb 8, 2017

Member

Tests:

  • base.php
  • occ
  • cron.php
  • OCS v1.php
  • OCS v2.php
  • remote.php
  • status.php
  • public.php / public link

All work 👍

Member

PVince81 commented Feb 8, 2017

Tests:

  • base.php
  • occ
  • cron.php
  • OCS v1.php
  • OCS v2.php
  • remote.php
  • status.php
  • public.php / public link

All work 👍

@PVince81 PVince81 added the blue-ticket label Feb 8, 2017

@PVince81 PVince81 merged commit 72226dd into stable8.2 Feb 8, 2017

4 checks passed

Scrutinizer 4 new issues, 3 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the stable8.2-autoloader-retry branch Feb 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment