Legacy example theme to app-theme (*wip*) #27162

Open
wants to merge 5 commits into
from

Projects

None yet

4 participants

@phisch
Contributor
phisch commented Feb 15, 2017

Description

Since we have updated the way themes are created, and we only support the old theme directory out of legacy theme support reasons, the example theme should get updated to the newer way of providing themes. That's what this PR is for.

Related Issue

owncloud/documentation#2844

Motivation and Context

Since the Documentation is currently being updated, we should update the theme so the documentation can reference to it as an example.

How Has This Been Tested?

This is just providing a theme through a different way. Will be tested by hand.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@phisch phisch deleted example theme from themes directory
6d834d7
@mention-bot

@phisch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @enoch85 to be a potential reviewer.

@phisch phisch self-assigned this Feb 15, 2017
@CLAassistant
CLAassistant commented Feb 15, 2017 edited

CLA assistant check
All committers have signed the CLA.

phisch added some commits Feb 15, 2017
@phisch phisch added example theme app to .gitignore exceptions 223912e
@phisch phisch added info.xml to example theme app
9462444
@phisch phisch added example theme images, logos, defaults and styles
ef13ded
apps/example-theme/appinfo/info.xml
+<?xml version="1.0"?>
+<info>
+ <id>example-theme</id>
+ <name>Example OwnCloud Theme</name>
apps/example-theme/appinfo/info.xml
+<info>
+ <id>example-theme</id>
+ <name>Example OwnCloud Theme</name>
+ <description>This App provides the example OwnCloud theme.</description>
@phisch phisch fixed ownCloud name
7f3a0bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment