Fix delete user dav hook to only delete users addressbooks #27169

merged 1 commit into from Feb 17, 2017


None yet

4 participants



On the deleteUser hook, only delete addressBooks that the user owns, not ones that have been shared with them.

Motivation and Context

Right now, if you delete a user, any addressbooks shared with them are also deleted.

How Has This Been Tested?

  • In the browser
  • Unit test updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@tomneedham tomneedham Fix delete user dav hook to only delete users addressbooks

@tomneedham, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @tcitworld and @stweil to be potential reviewers.

@tomneedham tomneedham requested a review from DeepDiver1975 Feb 15, 2017
@tomneedham tomneedham added this to the 10.0 milestone Feb 15, 2017
tomneedham commented Feb 15, 2017 edited
  • should be backported

Makes absolute sense 👍

@tomneedham please backport

@PVince81 PVince81 merged commit 6e2e13e into master Feb 17, 2017

4 checks passed

Scrutinizer 6 new issues, 13 updated code elements
continuous-integration/jenkins/pr-head This commit looks good
continuous-integration/travis-ci/pr The Travis CI build passed
licence/cla Contributor License Agreement is signed.
@PVince81 PVince81 deleted the preserve-shared-addressbooks branch Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment