Because unmerged shares existed only between OC 9.0.0 and 9.0.3 included and in OC <= 9.0.0, when someone updated to OC > 9.0.3 they already had the repair routine running.
Tested as follows:
Please review @VicDeo @jvillafanez @IljaN
Seems I broke the case where updating from OC 9.0.0...
Don't rerepair unmerged shares if updating from OC > 9.0.3
Fixed now and added unit test to enforce the version check.
Any reason why it's unsafe to rerun the repair step? Is it possible that unmerged shares will appear in the future?
The code looks fine, but I'm wondering if we're just putting a band-aid
It's not unsafe but it wastes time for huge setups as it can take many hours just for nothing.
Unmerged shares shouldn't reappear as they were a result of a bug (mostly missing logic that wasn't ported from the old sharing code to the new sharing code)
Ok, make sense. 👍