New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show system status in Settings/General #27238

Merged
merged 3 commits into from Feb 27, 2017

Conversation

Projects
None yet
4 participants
@mmattel
Contributor

mmattel commented Feb 23, 2017

@PVince81

Description

The status query is moved into a fuction making it available to be regualry called.
Printout of system details as you would see them like in status.php
Adding additional elements in the status query does not need additional code changes in the template.

Related Issue

#27231

Motivation and Context

This PR shows the elements like you see in ownclouddomain.com/status.php at the bottom of Settings/General

How Has This Been Tested?

call /settings/admin?sectionid=general and move to the bottom to see the result

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 23, 2017

@mmattel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bantu, @butonic and @DeepDiver1975 to be potential reviewers.

@mmattel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bantu, @butonic and @DeepDiver1975 to be potential reviewers.

@tomneedham tomneedham referenced this pull request Feb 23, 2017

Closed

Fixes #27231 #27237

4 of 9 tasks complete
@mmattel

This comment has been minimized.

Show comment
Hide comment
@mmattel

mmattel Feb 23, 2017

Contributor

Why did jenkins fail?

Contributor

mmattel commented Feb 23, 2017

Why did jenkins fail?

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Feb 24, 2017

Member

Seems you added a new public method:

@since or @deprecated tag is needed in PHPDoc for OCP\Util::getStatusInfo

you need to add @since 10.0 in its PHPDoc

Member

PVince81 commented Feb 24, 2017

Seems you added a new public method:

@since or @deprecated tag is needed in PHPDoc for OCP\Util::getStatusInfo

you need to add @since 10.0 in its PHPDoc

@PVince81 PVince81 added this to the 10.0 milestone Feb 27, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Feb 27, 2017

Member

Tested, works. 👍

Member

PVince81 commented Feb 27, 2017

Tested, works. 👍

@PVince81 PVince81 merged commit dbad94a into master Feb 27, 2017

4 checks passed

Scrutinizer 1 new issues, 5 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the show_status_in_general branch Feb 27, 2017

@Emil-G

This comment has been minimized.

Show comment
Hide comment
@Emil-G

Emil-G Jul 12, 2017

May I ask why the servername was not added to the admin pages as well?
cheers,
Emil

Emil-G commented Jul 12, 2017

May I ask why the servername was not added to the admin pages as well?
cheers,
Emil

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 12, 2017

Member

@Emil-G the admin page simply outputs whatever values are in status.php. If no server name is visible in status.php then it won't be visible there.

But maybe you meant to add it as additional info on this page regardless of status.php ? (the intent here was only about status.php)

Member

PVince81 commented Jul 12, 2017

@Emil-G the admin page simply outputs whatever values are in status.php. If no server name is visible in status.php then it won't be visible there.

But maybe you meant to add it as additional info on this page regardless of status.php ? (the intent here was only about status.php)

@Emil-G

This comment has been minimized.

Show comment
Hide comment
@Emil-G

Emil-G Jul 12, 2017

@PVince81 yes, that is what I was asking. That would be useful admin info when servers are clustered.

Emil-G commented Jul 12, 2017

@PVince81 yes, that is what I was asking. That would be useful admin info when servers are clustered.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 12, 2017

Member

@Emil-G raised here #28382

Member

PVince81 commented Jul 12, 2017

@Emil-G raised here #28382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment