[Stable9.1] Backporting logging changes of PR #27144 #27239

Merged
merged 2 commits into from Feb 27, 2017

Conversation

Projects
None yet
4 participants
@noveens
Contributor

noveens commented Feb 23, 2017

backporting logging changes of PR #27144

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Feb 23, 2017

@noveens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @DeepDiver1975 to be potential reviewers.

@noveens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @butonic and @DeepDiver1975 to be potential reviewers.

@noveens

This comment has been minimized.

Show comment
Hide comment
@noveens

noveens Feb 23, 2017

Contributor

@PVince81 ,
Is this the right way to do backporting?

Contributor

noveens commented Feb 23, 2017

@PVince81 ,
Is this the right way to do backporting?

lib/private/BackgroundJob/Job.php
+ $jobStartTime = time();
+
+ \OCP\Util::writeLog('cron', 'Started background job of class : ' . get_class($this) . ' with arguments : ' . print_r($this->argument, true), \OCP\Util::DEBUG
+ );

This comment has been minimized.

@jvillafanez

jvillafanez Feb 24, 2017

Member

Move the ); up or split the line better.

@jvillafanez

jvillafanez Feb 24, 2017

Member

Move the ); up or split the line better.

lib/private/BackgroundJob/Job.php
+ $timeTaken = $jobEndTime - $jobStartTime;
+
+ \OCP\Util::writeLog('cron', "Finished background job, the job took : $timeTaken seconds, " . "this job is an instance of class : " . get_class($this) . ' with arguments : ' . print_r($this->argument, true), \OCP\Util::DEBUG
+ );

This comment has been minimized.

@jvillafanez

jvillafanez Feb 24, 2017

Member

Move the ); up or split the line better.

@jvillafanez

jvillafanez Feb 24, 2017

Member

Move the ); up or split the line better.

@SergioBertolinSG SergioBertolinSG changed the title from backporting logging changes of PR #27144 to [Stable9.1] Backporting logging changes of PR #27144 Feb 24, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Feb 24, 2017

Member

Is this the right way to do backporting?

yes

Member

PVince81 commented Feb 24, 2017

Is this the right way to do backporting?

yes

@PVince81 PVince81 added this to the 9.1.5 milestone Feb 24, 2017

@noveens

This comment has been minimized.

Show comment
Hide comment
@noveens

noveens Feb 24, 2017

Contributor

@jvillafanez @PVince81 ,
updated the changes.

Contributor

noveens commented Feb 24, 2017

@jvillafanez @PVince81 ,
updated the changes.

@jvillafanez

This comment has been minimized.

Show comment
Hide comment
Member

jvillafanez commented Feb 27, 2017

👍

@noveens

This comment has been minimized.

Show comment
Hide comment
@noveens

noveens Feb 27, 2017

Contributor

@PVince81 ,
merge this?

Contributor

noveens commented Feb 27, 2017

@PVince81 ,
merge this?

@PVince81 PVince81 merged commit d61600c into owncloud:stable9.1 Feb 27, 2017

3 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@jvillafanez

This comment has been minimized.

Show comment
Hide comment
@jvillafanez

jvillafanez Feb 27, 2017

Member

Looks like we overlooked a missing whitespace...

{"reqId":"69jAKwn4pVcPHAaw32ds","remoteAddr":"82.159.139.58","app":"cron","message":"Finished background job, the job took : 0 seconds, this job is an instance of class : OC\\Command\\CommandJobwith arguments : O:33:\"OCA\\Files_Trashbin\\Command\\Expire\":1:{s:39:\"\u0000OCA\\Files_Trashbin\\Command\\Expire\u0000user\";s:5:\"admin\";}","level":0,"time":"2017-02-27T12:24:35+00:00","method":"GET","url":"\/cron.php","user":"--"}

Note the Command\\CommandJobwith arguments

@noveens could you create another PR to fix this?

Member

jvillafanez commented Feb 27, 2017

Looks like we overlooked a missing whitespace...

{"reqId":"69jAKwn4pVcPHAaw32ds","remoteAddr":"82.159.139.58","app":"cron","message":"Finished background job, the job took : 0 seconds, this job is an instance of class : OC\\Command\\CommandJobwith arguments : O:33:\"OCA\\Files_Trashbin\\Command\\Expire\":1:{s:39:\"\u0000OCA\\Files_Trashbin\\Command\\Expire\u0000user\";s:5:\"admin\";}","level":0,"time":"2017-02-27T12:24:35+00:00","method":"GET","url":"\/cron.php","user":"--"}

Note the Command\\CommandJobwith arguments

@noveens could you create another PR to fix this?

@noveens

This comment has been minimized.

Show comment
Hide comment
@noveens

noveens Feb 27, 2017

Contributor

@jvillafanez ,
PR on the way.

Contributor

noveens commented Feb 27, 2017

@jvillafanez ,
PR on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment