fix objectstore rename #27281

Merged
merged 3 commits into from Mar 9, 2017

Conversation

Projects
None yet
5 participants
@butonic
Member

butonic commented Mar 1, 2017

Description

This PR makes oc keep the old fileId when using PUT. Objectstorage implementations do not need a part file. Metadata is kept in the filecache, no scanning is possible.

Motivation and Context

fileids must be stable or shares, tags and comments get lost

How Has This Been Tested?

locally with minio and the desktop client.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 1, 2017

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975 to be a potential reviewer.

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 1, 2017

Member

When trying to use objectstore in master I am getting an internal error. Creation of new files is not allowed.

(using 9.1.4 works fine)

{"reqId":"liPFTFOdsjws6RY6B3oX","remoteAddr":"HIDDEN_IP","app":"index","message":"Exception: {\"Exception\":\"OCP\\\\Files\\\\NotFoundException\",\"Message\":\"\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/apps\\\/files\\\/lib\\\/Controller\\\/ViewController.php(135): OC_Helper::getStorageInfo('\\\/', false)\\n#1 \\\/opt\\\/owncloud\\\/apps\\\/files\\\/lib\\\/Controller\\\/ViewController.php(206): OCA\\\\Files\\\\Controller\\\\ViewController->getStorageInfo()\\n#2 [internal function]: OCA\\\\Files\\\\Controller\\\\ViewController->index('', '', NULL)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(159): call_user_func_array(Array, Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\Files\\\\Controller\\\\ViewController), 'index')\\n#5 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/App.php(98): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\Files\\\\Controller\\\\ViewController), 'index')\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Routing\\\/RouteActionHandler.php(46): OC\\\\AppFramework\\\\App::main('ViewController', 'index', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#7 [internal function]: OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler->__invoke(Array)\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(299): call_user_func(Object(OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler), Array)\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/base.php(898): OC\\\\Route\\\\Router->match('\\\/apps\\\/files\\\/')\\n#10 \\\/opt\\\/owncloud\\\/index.php(49): OC::handleRequest()\\n#11 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/helper.php\",\"Line\":570}","level":3,"time":"2017-03-01T11:28:43+00:00","method":"GET","url":"\/index.php\/apps\/files\/","user":"admin"}
Member

SergioBertolinSG commented Mar 1, 2017

When trying to use objectstore in master I am getting an internal error. Creation of new files is not allowed.

(using 9.1.4 works fine)

{"reqId":"liPFTFOdsjws6RY6B3oX","remoteAddr":"HIDDEN_IP","app":"index","message":"Exception: {\"Exception\":\"OCP\\\\Files\\\\NotFoundException\",\"Message\":\"\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/apps\\\/files\\\/lib\\\/Controller\\\/ViewController.php(135): OC_Helper::getStorageInfo('\\\/', false)\\n#1 \\\/opt\\\/owncloud\\\/apps\\\/files\\\/lib\\\/Controller\\\/ViewController.php(206): OCA\\\\Files\\\\Controller\\\\ViewController->getStorageInfo()\\n#2 [internal function]: OCA\\\\Files\\\\Controller\\\\ViewController->index('', '', NULL)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(159): call_user_func_array(Array, Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\Files\\\\Controller\\\\ViewController), 'index')\\n#5 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/App.php(98): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\Files\\\\Controller\\\\ViewController), 'index')\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Routing\\\/RouteActionHandler.php(46): OC\\\\AppFramework\\\\App::main('ViewController', 'index', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#7 [internal function]: OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler->__invoke(Array)\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(299): call_user_func(Object(OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler), Array)\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/base.php(898): OC\\\\Route\\\\Router->match('\\\/apps\\\/files\\\/')\\n#10 \\\/opt\\\/owncloud\\\/index.php(49): OC::handleRequest()\\n#11 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/helper.php\",\"Line\":570}","level":3,"time":"2017-03-01T11:28:43+00:00","method":"GET","url":"\/index.php\/apps\/files\/","user":"admin"}
@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 1, 2017

Member

@SergioBertolinSG I assume the files folder tor the home storage of your user ha not been created:

try

--- a/lib/private/Files/ObjectStore/HomeObjectStoreStorage.php
+++ b/lib/private/Files/ObjectStore/HomeObjectStoreStorage.php
@@ -37,6 +37,10 @@ class HomeObjectStoreStorage extends ObjectStoreStorage implements \OCP\Files\IH
                }
                $this->user = $params['user'];
                parent::__construct($params);
+               //initialize cache with files directory
+               if ( ! $this->is_dir('files') ) {
+                       $this->mkdir('files');
+               }
        }
 
        public function getId () {
Member

butonic commented Mar 1, 2017

@SergioBertolinSG I assume the files folder tor the home storage of your user ha not been created:

try

--- a/lib/private/Files/ObjectStore/HomeObjectStoreStorage.php
+++ b/lib/private/Files/ObjectStore/HomeObjectStoreStorage.php
@@ -37,6 +37,10 @@ class HomeObjectStoreStorage extends ObjectStoreStorage implements \OCP\Files\IH
                }
                $this->user = $params['user'];
                parent::__construct($params);
+               //initialize cache with files directory
+               if ( ! $this->is_dir('files') ) {
+                       $this->mkdir('files');
+               }
        }
 
        public function getId () {
@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 1, 2017

Member

Adding this code the starting internal error is gone. But the creation of files is still failing. Creating a text file shows an error, the file is created but cannot be opened. Also uploading a picture cannot be opened also.

{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"Cannot open file: <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>NoSuchKey<\/Code><Message>The specified key does not exist.<\/Message><Key><\/Key><BucketName><\/BucketName><Resource>\/hola2\/urn:oid:62<\/Resource><RequestId>3L137<\/RequestId><HostId>3L137<\/HostId><\/Error> at \/opt\/owncloud\/apps\/objectstore\/3rdparty\/aws-sdk-php\/Aws\/S3\/StreamWrapper.php#774","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fopen(s3:\/\/hola2\/urn:oid:62): failed to open stream: &quot;Aws\\S3\\StreamWrapper::stream_open&quot; call failed at \/opt\/owncloud\/apps\/objectstore\/lib\/s3.php#137","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fread() expects parameter 1 to be resource, boolean given at \/opt\/owncloud\/lib\/private\/Files\/Storage\/Wrapper\/Encryption.php#849","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fclose() expects parameter 1 to be resource, boolean given at \/opt\/owncloud\/lib\/private\/Files\/Storage\/Wrapper\/Encryption.php#850","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"Cannot open file: <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>NoSuchKey<\/Code><Message>The specified key does not exist.<\/Message><Key><\/Key><BucketName><\/BucketName><Resource>\/hola2\/urn:oid:62<\/Resource><RequestId>3L137<\/RequestId><HostId>3L137<\/HostId><\/Error> at \/opt\/owncloud\/apps\/objectstore\/3rdparty\/aws-sdk-php\/Aws\/S3\/StreamWrapper.php#774","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fopen(s3:\/\/hola2\/urn:oid:62): failed to open stream: &quot;Aws\\S3\\StreamWrapper::stream_open&quot; call failed at \/opt\/owncloud\/apps\/objectstore\/lib\/s3.php#137","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
Member

SergioBertolinSG commented Mar 1, 2017

Adding this code the starting internal error is gone. But the creation of files is still failing. Creating a text file shows an error, the file is created but cannot be opened. Also uploading a picture cannot be opened also.

{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"Cannot open file: <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>NoSuchKey<\/Code><Message>The specified key does not exist.<\/Message><Key><\/Key><BucketName><\/BucketName><Resource>\/hola2\/urn:oid:62<\/Resource><RequestId>3L137<\/RequestId><HostId>3L137<\/HostId><\/Error> at \/opt\/owncloud\/apps\/objectstore\/3rdparty\/aws-sdk-php\/Aws\/S3\/StreamWrapper.php#774","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fopen(s3:\/\/hola2\/urn:oid:62): failed to open stream: &quot;Aws\\S3\\StreamWrapper::stream_open&quot; call failed at \/opt\/owncloud\/apps\/objectstore\/lib\/s3.php#137","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fread() expects parameter 1 to be resource, boolean given at \/opt\/owncloud\/lib\/private\/Files\/Storage\/Wrapper\/Encryption.php#849","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fclose() expects parameter 1 to be resource, boolean given at \/opt\/owncloud\/lib\/private\/Files\/Storage\/Wrapper\/Encryption.php#850","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"Cannot open file: <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>NoSuchKey<\/Code><Message>The specified key does not exist.<\/Message><Key><\/Key><BucketName><\/BucketName><Resource>\/hola2\/urn:oid:62<\/Resource><RequestId>3L137<\/RequestId><HostId>3L137<\/HostId><\/Error> at \/opt\/owncloud\/apps\/objectstore\/3rdparty\/aws-sdk-php\/Aws\/S3\/StreamWrapper.php#774","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
{"reqId":"uSAylhoZliIjZE6Btlxl","remoteAddr":"HIDDEN_IP","app":"PHP","message":"fopen(s3:\/\/hola2\/urn:oid:62): failed to open stream: &quot;Aws\\S3\\StreamWrapper::stream_open&quot; call failed at \/opt\/owncloud\/apps\/objectstore\/lib\/s3.php#137","level":3,"time":"2017-03-01T12:42:18+00:00","method":"GET","url":"\/index.php\/apps\/files_texteditor\/ajax\/loadfile?filename=texto.txt&dir=%2F","user":"paco"}
@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 1, 2017

Member

well, you know ... what error?

Member

butonic commented Mar 1, 2017

well, you know ... what error?

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
Member

SergioBertolinSG commented Mar 1, 2017

screen shot 2017-03-01 at 13 54 16

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 1, 2017

Member

@SergioBertolinSG anything in the log?

Member

butonic commented Mar 1, 2017

@SergioBertolinSG anything in the log?

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 1, 2017

Member

Yes I've added it in #27281 (comment)

Member

SergioBertolinSG commented Mar 1, 2017

Yes I've added it in #27281 (comment)

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 1, 2017

Member

hm, what objectstorage are you testing against

Member

butonic commented Mar 1, 2017

hm, what objectstorage are you testing against

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 1, 2017

Member

hm, what objectstorage are you testing against

Minio https://hub.docker.com/r/webhippie/minio/

Member

SergioBertolinSG commented Mar 1, 2017

hm, what objectstorage are you testing against

Minio https://hub.docker.com/r/webhippie/minio/

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 1, 2017

Member

I can reproduce. It seems the files don't even make it to minio ... actually it doas, but is immediately deleted ... meh, this PR needs rework.

Member

butonic commented Mar 1, 2017

I can reproduce. It seems the files don't even make it to minio ... actually it doas, but is immediately deleted ... meh, this PR needs rework.

@butonic butonic added 2 - Developing and removed 3 - To Review labels Mar 1, 2017

@butonic butonic changed the title from fix objectstore rename to [WIP] fix objectstore rename Mar 1, 2017

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 1, 2017

Member

@SergioBertolinSG can you test again?

Member

butonic commented Mar 1, 2017

@SergioBertolinSG can you test again?

@butonic butonic changed the title from [WIP] fix objectstore rename to fix objectstore rename Mar 1, 2017

@butonic butonic added 3 - To Review and removed 2 - Developing labels Mar 1, 2017

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 1, 2017

Member

But the code added in #27281 (comment) is not included in this PR, so that is still failing.

Member

SergioBertolinSG commented Mar 1, 2017

But the code added in #27281 (comment) is not included in this PR, so that is still failing.

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 1, 2017

Member

Adding those lines it is working fine.

Also issue is fixed.

Member

SergioBertolinSG commented Mar 1, 2017

Adding those lines it is working fine.

Also issue is fixed.

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 2, 2017

Member

ok, I have not yet found out why sometimes the files folder is not created. It should be created automatically on the first login of a user. My feeling is that it has to do with copying the skeleton... @SergioBertolinSG can you try reverting the patch from #27281 (comment) and logging in with a new user?

Member

butonic commented Mar 2, 2017

ok, I have not yet found out why sometimes the files folder is not created. It should be created automatically on the first login of a user. My feeling is that it has to do with copying the skeleton... @SergioBertolinSG can you try reverting the patch from #27281 (comment) and logging in with a new user?

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Mar 2, 2017

Member

Reverting #27281 (comment) and creating a new user has worked fine.

Seems to be only a problem with admin user (first user) at first login.

Member

SergioBertolinSG commented Mar 2, 2017

Reverting #27281 (comment) and creating a new user has worked fine.

Seems to be only a problem with admin user (first user) at first login.

@butonic butonic requested a review from phisch Mar 8, 2017

@butonic butonic added the blue-ticket label Mar 8, 2017

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 8, 2017

Member

backport to 9.1 requested

Member

butonic commented Mar 8, 2017

backport to 9.1 requested

@SergioBertolinSG

Nothing has changed. First run throws an error. Admin user's files cannot be created.

{"reqId":"xkdzGqIxkNZteI3chXrB","remoteAddr":"HIDDEN_IP","app":"index","message":"Exception: {\"Exception\":\"OCP\\\\Files\\\\NotFoundException\",\"Message\":\"\",\"Code\":0,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/apps\\\/files\\\/lib\\\/Controller\\\/ViewController.php(135): OC_Helper::getStorageInfo('\\\/', false)\\n#1 \\\/opt\\\/owncloud\\\/apps\\\/files\\\/lib\\\/Controller\\\/ViewController.php(206): OCA\\\\Files\\\\Controller\\\\ViewController->getStorageInfo()\\n#2 [internal function]: OCA\\\\Files\\\\Controller\\\\ViewController->index('', '', NULL)\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(159): call_user_func_array(Array, Array)\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\Files\\\\Controller\\\\ViewController), 'index')\\n#5 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/App.php(98): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\Files\\\\Controller\\\\ViewController), 'index')\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Routing\\\/RouteActionHandler.php(46): OC\\\\AppFramework\\\\App::main('ViewController', 'index', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#7 [internal function]: OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler->__invoke(Array)\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(299): call_user_func(Object(OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler), Array)\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/base.php(898): OC\\\\Route\\\\Router->match('\\\/apps\\\/files\\\/')\\n#10 \\\/opt\\\/owncloud\\\/index.php(49): OC::handleRequest()\\n#11 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/lib\\\/private\\\/legacy\\\/helper.php\",\"Line\":570}","level":3,"time":"2017-03-08T16:28:50+00:00","method":"GET","url":"\/index.php\/apps\/files\/","user":"admin"}
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 8, 2017

Member

Seems #25826 is overdue (let storages tell whether they need part files or not). I'll tag it as junior job 😉

Member

PVince81 commented Mar 8, 2017

Seems #25826 is overdue (let storages tell whether they need part files or not). I'll tag it as junior job 😉

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 8, 2017

Member

Nothing has changed. First run throws an error. Admin user's files cannot be created

unrelated to the original issue, as you yourself said in #27281 (comment)

Member

butonic commented Mar 8, 2017

Nothing has changed. First run throws an error. Admin user's files cannot be created

unrelated to the original issue, as you yourself said in #27281 (comment)

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 9, 2017

Member

@butonic

Unit test needs adjustment:

17:36:28 1) OCA\DAV\Tests\unit\Connector\Sabre\FileTest::testPutSingleFileCancelPreHook
17:36:28 Failed asserting that false is true.
17:36:28 
17:36:28 /var/lib/jenkins/workspace/owncloud-core_core_PR-27281-ZLEMELGGQSHOW5XAXE7CTMNN3YKEXHZEQRZ6O7WK7AO32G534PTQ/apps/dav/tests/unit/Connector/Sabre/FileTest.php:535
Member

PVince81 commented Mar 9, 2017

@butonic

Unit test needs adjustment:

17:36:28 1) OCA\DAV\Tests\unit\Connector\Sabre\FileTest::testPutSingleFileCancelPreHook
17:36:28 Failed asserting that false is true.
17:36:28 
17:36:28 /var/lib/jenkins/workspace/owncloud-core_core_PR-27281-ZLEMELGGQSHOW5XAXE7CTMNN3YKEXHZEQRZ6O7WK7AO32G534PTQ/apps/dav/tests/unit/Connector/Sabre/FileTest.php:535
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 9, 2017

Member

Selenium test failure unrelated, merging.

Member

PVince81 commented Mar 9, 2017

Selenium test failure unrelated, merging.

@PVince81 PVince81 merged commit 1661431 into master Mar 9, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
licence/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the fix-objectstore-rename branch Mar 9, 2017

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 9, 2017

Member

backport request to 9.1

Member

butonic commented Mar 9, 2017

backport request to 9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment