use closure to properly defer l10n initialization #27328

Merged
merged 1 commit into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@butonic
Member

butonic commented Mar 7, 2017

Description

fixes translation of web ui for ldap users. backport to 9.1 requested

Related Issue

Motivation and Context

Mixed language in the UI.

How Has This Been Tested?

locally, with ldap and german, english, spanish language mix.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@butonic butonic added this to the 10.0 milestone Mar 7, 2017

@butonic butonic requested review from PVince81 and DeepDiver1975 Mar 7, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 7, 2017

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975, @Gadzy and @Xenopathic to be potential reviewers.

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @PVince81, @DeepDiver1975, @Gadzy and @Xenopathic to be potential reviewers.

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic Mar 7, 2017

Member

waiting for CI will then backport.

also, I don't know if I catched all occurrences of this. I certainly did not catch the ones in other apps ... how do we enforce them to defer initialization ... The problem is that $l is initialized in app.php ... way before the user preferences have been loaded.

I guess we need to log a warning when anything but a closure is used?

Member

butonic commented Mar 7, 2017

waiting for CI will then backport.

also, I don't know if I catched all occurrences of this. I certainly did not catch the ones in other apps ... how do we enforce them to defer initialization ... The problem is that $l is initialized in app.php ... way before the user preferences have been loaded.

I guess we need to log a warning when anything but a closure is used?

@butonic butonic changed the title from use closer to properly defer l10n initialization to use closure to properly defer l10n initialization Mar 7, 2017

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
Member

DeepDiver1975 commented Mar 7, 2017

👍

@DeepDiver1975 DeepDiver1975 merged commit 8e36c55 into master Mar 7, 2017

3 of 4 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the fix-translation branch Mar 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment