[stable9.1] Custom Authentication Mechanisms for WebDAV and APIs #27370

Merged
merged 2 commits into from Mar 21, 2017

Conversation

Projects
None yet
4 participants
@joneug
Contributor

joneug commented Mar 13, 2017

Description

This is a backport of #26742 to stable9. It would be great to update sabre/dav to 3.2 (as in master), too, because it would simplify the implementation of Bearer Authentication.

Related Issue

#10400

Motivation and Context

This, for example, allows the implementation of Bearer Authentication with OAuth 2.0 (see OAuth 2.0 app).

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 13, 2017

@joneug, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @tomneedham and @DeepDiver1975 to be potential reviewers.

@joneug, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ChristophWurst, @tomneedham and @DeepDiver1975 to be potential reviewers.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 13, 2017

Member

It would be great to update sabre/dav to 3.2

We don't update major library versions in minor releases, sorry. This is likely to cause a lot of breakage.

Member

PVince81 commented Mar 13, 2017

It would be great to update sabre/dav to 3.2

We don't update major library versions in minor releases, sorry. This is likely to cause a lot of breakage.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 13, 2017

Member

@DeepDiver1975 can you restart the Jenkins job ? Not sure why this specific random failure is back

Member

PVince81 commented Mar 13, 2017

@DeepDiver1975 can you restart the Jenkins job ? Not sure why this specific random failure is back

@joneug

This comment has been minimized.

Show comment
Hide comment
@joneug

joneug Mar 15, 2017

Contributor

We don't update major library versions in minor releases, sorry. This is likely to cause a lot of breakage.

I see.

@DeepDiver1975 can you restart the Jenkins job ? Not sure why this specific random failure is back

That would be great.

Contributor

joneug commented Mar 15, 2017

We don't update major library versions in minor releases, sorry. This is likely to cause a lot of breakage.

I see.

@DeepDiver1975 can you restart the Jenkins job ? Not sure why this specific random failure is back

That would be great.

@joneug

This comment has been minimized.

Show comment
Hide comment
@joneug

joneug Mar 17, 2017

Contributor

@PVince81 Are we ready to merge?

Contributor

joneug commented Mar 17, 2017

@PVince81 Are we ready to merge?

@joneug

This comment has been minimized.

Show comment
Hide comment
@joneug

joneug Mar 20, 2017

Contributor

Or is there something to change?

Contributor

joneug commented Mar 20, 2017

Or is there something to change?

@PVince81

This comment has been minimized.

Show comment
Hide comment
Member

PVince81 commented Mar 20, 2017

@DeepDiver1975 @phisch please review

@joneug joneug referenced this pull request in owncloud/oauth2 Mar 20, 2017

Merged

Add compatibility with ownCloud 9.1 #28

@DeepDiver1975 DeepDiver1975 added this to the 9.1.5 milestone Mar 21, 2017

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
Member

DeepDiver1975 commented Mar 21, 2017

👍

@DeepDiver1975 DeepDiver1975 merged commit 04cfdda into owncloud:stable9.1 Mar 21, 2017

3 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@joneug joneug referenced this pull request in owncloud/oauth2 Mar 26, 2017

Closed

Update min-version #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment