[stable8.2] Add proxy support to external storage #27410

Merged
merged 1 commit into from Mar 20, 2017

Conversation

Projects
None yet
4 participants
@PVince81
Member

PVince81 commented Mar 17, 2017

Partial backport of #22636.

Only the proxy setting part for Webdav.

@pako81 @phisch @butonic @jvillafanez

Add proxy support to external storage
Otherwise debugging issues is a PITA

@PVince81 PVince81 added this to the 8.2.11 milestone Mar 17, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 17, 2017

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @DeepDiver1975 and @LukasReschke to be potential reviewers.

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @DeepDiver1975 and @LukasReschke to be potential reviewers.

@it25fg

This comment has been minimized.

Show comment
Hide comment
@it25fg

it25fg Mar 17, 2017

I have applied the patch to an 8.2.9 test instance and can verify that all WEBDAV requests now use the configured proxy. I can't know if there are other code paths. The requests I have tested were caused only by a 'share by link' and subsequent 'add to your owncloud'. Thanks for nailing down the issue.

it25fg commented Mar 17, 2017

I have applied the patch to an 8.2.9 test instance and can verify that all WEBDAV requests now use the configured proxy. I can't know if there are other code paths. The requests I have tested were caused only by a 'share by link' and subsequent 'add to your owncloud'. Thanks for nailing down the issue.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 20, 2017

Member

Thanks for confirming, merging

Member

PVince81 commented Mar 20, 2017

Thanks for confirming, merging

@PVince81 PVince81 merged commit bf5207a into stable8.2 Mar 20, 2017

4 checks passed

Scrutinizer 6 new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the stable8.2-dav-proxy branch Mar 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment