New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send password change notification #27498

Merged
merged 2 commits into from Mar 27, 2017

Conversation

Projects
None yet
4 participants
@imujjwal96
Contributor

imujjwal96 commented Mar 24, 2017

Description

Whenever the password of a user is changed, either by

  1. Changing from Settings/Personal, or
  2. Changing from Admin's Settings/Users, or
  3. Resetting password
    an email is sent notifying the change of password

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 24, 2017

@imujjwal96, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @VicDeo and @Kondou-ger to be potential reviewers.

@imujjwal96, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @VicDeo and @Kondou-ger to be potential reviewers.

@PVince81 PVince81 added this to the 10.0 milestone Mar 27, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 27, 2017

Member

Makes sense, I'll test this.

@pmaier1 agree with the concept ? Basically a user always receives an email whenever they or someone changes their password.

Member

PVince81 commented Mar 27, 2017

Makes sense, I'll test this.

@pmaier1 agree with the concept ? Basically a user always receives an email whenever they or someone changes their password.

@hodyroff

This comment has been minimized.

Show comment
Hide comment
@hodyroff

hodyroff Mar 27, 2017

Contributor

Like it. At some point somebody will want this to be configurable under personal settings ...

Contributor

hodyroff commented Mar 27, 2017

Like it. At some point somebody will want this to be configurable under personal settings ...

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Mar 27, 2017

Member

Tested, works 👍

Ideally the email contents should say "Password was changed by the administrator". This could be done in a separate PR.

Member

PVince81 commented Mar 27, 2017

Tested, works 👍

Ideally the email contents should say "Password was changed by the administrator". This could be done in a separate PR.

@PVince81 PVince81 merged commit 11acd94 into owncloud:master Mar 27, 2017

4 checks passed

Scrutinizer 5 new issues, 3 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment