New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder the entries of the log for easier reading #27562

Merged
merged 1 commit into from Apr 4, 2017

Conversation

Projects
None yet
2 participants
@jvillafanez
Member

jvillafanez commented Apr 4, 2017

Description

Reorder log entries

Related Issue

Fix #27397 , related to #27447

Motivation and Context

Make the logs easier to read

How Has This Been Tested?

Checked the logs manually

Screenshots (if appropriate):

{"reqId":"heXNVIiTLeSrcxje601b","level":2,"time":"2017-04-04T07:19:16+00:00","remoteAddr":"10.0.2.4","user":"--","app":"core","method":"POST","url":"\/index.php\/login","message":"Login failed: 'admin' (Remote IP: '10.0.2.4')"}
{"reqId":"FqAaWU6uA5RAAJ7IwbNZ","level":2,"time":"2017-04-04T07:19:27+00:00","remoteAddr":"10.0.2.4","user":"--","app":"core","method":"POST","url":"\/index.php\/login?user=admin","message":"Login failed: 'admin' (Remote IP: '10.0.2.4')"}
{"reqId":"2FtXpg0TAg4qsffAzu6t","level":3,"time":"2017-04-04T07:19:48+00:00","remoteAddr":"10.0.2.4","user":"admin","app":"webdav","method":"PUT","url":"\/remote.php\/webdav\/SMB\/Circuit.png","message":"\\OC\\Files\\Filesystem::fopen() failed"}
{"reqId":"2FtXpg0TAg4qsffAzu6t","level":4,"time":"2017-04-04T07:19:48+00:00","remoteAddr":"10.0.2.4","user":"admin","app":"webdav","method":"PUT","url":"\/remote.php\/webdav\/SMB\/Circuit.png","message":"Exception: {\"Message\":\"Unknown error (30) for smb:\\\/\\\/10.0.2.6\\\/ro\\\/Circuit.png.ocTransferId1862609.part\",\"Exception\":\"Icewind\\\\SMB\\\\Exception\\\\Exception\",\"Code\":30,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeState.php(72): Icewind\\\\SMB\\\\NativeState->handleError('smb:\\\/\\\/10.0.2.6\\\/...')\\n#1 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeState.php(146): Icewind\\\\SMB\\\\NativeState->testResult(false, 'smb:\\\/\\\/10.0.2.6\\\/...')\\n#2 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeShare.php(150): Icewind\\\\SMB\\\\NativeState->unlink('smb:\\\/\\\/10.0.2.6\\\/...')\\n#3 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/lib\\\/Lib\\\/Storage\\\/SMB.php(352): Icewind\\\\SMB\\\\NativeShare->del('\\\/Circuit.png.oc...')\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(261): OCA\\\\Files_External\\\\Lib\\\\Storage\\\\SMB->unlink('\\\/Circuit.png.oc...')\\n#5 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/PermissionsMask.php(107): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->unlink('Circuit.png.ocT...')\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(261): OC\\\\Files\\\\Storage\\\\Wrapper\\\\PermissionsMask->unlink('Circuit.png.ocT...')\\n#7 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Availability.php(284): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->unlink('Circuit.png.ocT...')\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Encryption.php(254): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Availability->unlink('Circuit.png.ocT...')\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(261): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Encryption->unlink('Circuit.png.ocT...')\\n#10 [internal function]: OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->unlink('Circuit.png.ocT...')\\n#11 \\\/opt\\\/owncloud\\\/apps\\\/files_trashbin\\\/lib\\\/Storage.php(169): call_user_func_array(Array, Array)\\n#12 \\\/opt\\\/owncloud\\\/apps\\\/files_trashbin\\\/lib\\\/Storage.php(120): OCA\\\\Files_Trashbin\\\\Storage->doDelete('Circuit.png.ocT...', 'unlink')\\n#13 \\\/opt\\\/owncloud\\\/apps\\\/workflow\\\/lib\\\/Engine\\\/Wrapper\\\/StorageWrapper.php(366): OCA\\\\Files_Trashbin\\\\Storage->unlink('Circuit.png.ocT...')\\n#14 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php(162): OCA\\\\Workflow\\\\Engine\\\\Wrapper\\\\StorageWrapper->unlink('Circuit.png.ocT...')\\n#15 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/Directory.php(150): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->put(Resource id #70)\\n#16 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1095): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\Directory->createFile('Circuit.png', Resource id #70)\\n#17 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(525): Sabre\\\\DAV\\\\Server->createFile('SMB\\\/Circuit.png', Resource id #70, NULL)\\n#18 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpPut(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#19 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#20 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:PUT', Array)\\n#21 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#22 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(63): Sabre\\\\DAV\\\\Server->exec()\\n#23 \\\/opt\\\/owncloud\\\/remote.php(165): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#24 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeState.php\",\"Line\":66,\"User\":\"admin\"}"}
{"reqId":"uP2Bt0e3pXLMSCkIg8xl","level":3,"time":"2017-04-04T08:05:27+00:00","remoteAddr":"10.0.2.4","user":"qwerty","app":"webdav","method":"PUT","url":"\/remote.php\/webdav\/SMB\/iio.txt","message":"\\OC\\Files\\Filesystem::fopen() failed"}
{"reqId":"uP2Bt0e3pXLMSCkIg8xl","level":4,"time":"2017-04-04T08:05:27+00:00","remoteAddr":"10.0.2.4","user":"qwerty","app":"webdav","method":"PUT","url":"\/remote.php\/webdav\/SMB\/iio.txt","message":"Exception: {\"Message\":\"Unknown error (30) for smb:\\\/\\\/10.0.2.6\\\/ro\\\/iio.txt.ocTransferId1913855175.part\",\"Exception\":\"Icewind\\\\SMB\\\\Exception\\\\Exception\",\"Code\":30,\"Trace\":\"#0 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeState.php(72): Icewind\\\\SMB\\\\NativeState->handleError('smb:\\\/\\\/10.0.2.6\\\/...')\\n#1 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeState.php(146): Icewind\\\\SMB\\\\NativeState->testResult(false, 'smb:\\\/\\\/10.0.2.6\\\/...')\\n#2 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeShare.php(150): Icewind\\\\SMB\\\\NativeState->unlink('smb:\\\/\\\/10.0.2.6\\\/...')\\n#3 \\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/lib\\\/Lib\\\/Storage\\\/SMB.php(352): Icewind\\\\SMB\\\\NativeShare->del('\\\/iio.txt.ocTran...')\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(261): OCA\\\\Files_External\\\\Lib\\\\Storage\\\\SMB->unlink('\\\/iio.txt.ocTran...')\\n#5 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/PermissionsMask.php(107): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->unlink('iio.txt.ocTrans...')\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(261): OC\\\\Files\\\\Storage\\\\Wrapper\\\\PermissionsMask->unlink('iio.txt.ocTrans...')\\n#7 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Availability.php(284): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->unlink('iio.txt.ocTrans...')\\n#8 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Encryption.php(254): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Availability->unlink('iio.txt.ocTrans...')\\n#9 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(261): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Encryption->unlink('iio.txt.ocTrans...')\\n#10 [internal function]: OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->unlink('iio.txt.ocTrans...')\\n#11 \\\/opt\\\/owncloud\\\/apps\\\/files_trashbin\\\/lib\\\/Storage.php(169): call_user_func_array(Array, Array)\\n#12 \\\/opt\\\/owncloud\\\/apps\\\/files_trashbin\\\/lib\\\/Storage.php(120): OCA\\\\Files_Trashbin\\\\Storage->doDelete('iio.txt.ocTrans...', 'unlink')\\n#13 \\\/opt\\\/owncloud\\\/apps\\\/workflow\\\/lib\\\/Engine\\\/Wrapper\\\/StorageWrapper.php(366): OCA\\\\Files_Trashbin\\\\Storage->unlink('iio.txt.ocTrans...')\\n#14 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/File.php(162): OCA\\\\Workflow\\\\Engine\\\\Wrapper\\\\StorageWrapper->unlink('iio.txt.ocTrans...')\\n#15 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/Directory.php(150): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\File->put(Resource id #70)\\n#16 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1095): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\Directory->createFile('iio.txt', Resource id #70)\\n#17 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(525): Sabre\\\\DAV\\\\Server->createFile('SMB\\\/iio.txt', Resource id #70, NULL)\\n#18 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpPut(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#19 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#20 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:PUT', Array)\\n#21 \\\/opt\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#22 \\\/opt\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(63): Sabre\\\\DAV\\\\Server->exec()\\n#23 \\\/opt\\\/owncloud\\\/remote.php(165): require_once('\\\/opt\\\/owncloud\\\/a...')\\n#24 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/apps\\\/files_external\\\/3rdparty\\\/icewind\\\/smb\\\/src\\\/NativeState.php\",\"Line\":66,\"User\":\"qwerty\"}"}
{"reqId":"a5vzz2EBSUEEuYNXuPws","level":2,"time":"2017-04-04T08:06:29+00:00","remoteAddr":"10.0.2.4","user":"qwerty","app":"core","method":"POST","url":"\/index.php\/settings\/personal\/changepassword","message":"Login failed: 'qwerty' (Remote IP: '10.0.2.4')"}
{"reqId":"w5daBbCfcH1hT7B79IzG","level":3,"time":"2017-04-04T08:07:15+00:00","remoteAddr":"10.0.2.4","user":"qwerty","app":"no app in context","method":"POST","url":"\/ocs\/v2.php\/apps\/files_sharing\/api\/v1\/shares?format=json","message":"Failed to notify remote server of federated share, removing share (Sharing Photos failed, could not find user1@example.com, maybe the server is currently unreachable.)"}
{"reqId":"Ny0BwyfDItClXRn3SM94","level":2,"time":"2017-04-04T08:08:05+00:00","remoteAddr":"10.0.2.4","user":"--","app":"core","method":"POST","url":"\/index.php\/login","message":"Login failed: 'admin' (Remote IP: '10.0.2.4')"}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jvillafanez jvillafanez added this to the 10.0 milestone Apr 4, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 4, 2017

Member

👍

Member

PVince81 commented Apr 4, 2017

👍

@PVince81 PVince81 merged commit 12381b9 into master Apr 4, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the log_entry_reorder branch Apr 4, 2017

@jvillafanez jvillafanez referenced this pull request Apr 4, 2017

Closed

Reorder log entries #27447

3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment