New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "local link" to "private link" #27594

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
3 participants
@PVince81
Member

PVince81 commented Apr 7, 2017

@pmaier1 @felixheidecke please review

private_link

Fixes #27593

@PVince81 PVince81 added this to the 10.0.1 milestone Apr 7, 2017

@PVince81 PVince81 referenced this pull request Apr 7, 2017

Closed

Change name of 'local/permanent link' to 'private link' #27593

0 of 2 tasks complete
@pmaier1

This comment has been minimized.

Show comment
Hide comment
@pmaier1

pmaier1 Apr 7, 2017

Contributor

Great! 👍

Contributor

pmaier1 commented Apr 7, 2017

Great! 👍

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 7, 2017

Member

I find this big block to be a bit heavy, but ok.

If @felixheidecke doesn't object we can merge this.

Member

PVince81 commented Apr 7, 2017

I find this big block to be a bit heavy, but ok.

If @felixheidecke doesn't object we can merge this.

@pmaier1

This comment has been minimized.

Show comment
Hide comment
@pmaier1

pmaier1 Apr 7, 2017

Contributor

I find this big block to be a bit heavy, but ok.

True. Maybe @felixheidecke comes up with a better idea, otherwise I'm fine with this as it's definitely better than no explanation.

Contributor

pmaier1 commented Apr 7, 2017

I find this big block to be a bit heavy, but ok.

True. Maybe @felixheidecke comes up with a better idea, otherwise I'm fine with this as it's definitely better than no explanation.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 7, 2017

Member

I don't think we can add line breaks in a tooltip, so if there is a better way it will like have to be a different revamped UI. I think I'll merge this for now.

Member

PVince81 commented Apr 7, 2017

I don't think we can add line breaks in a tooltip, so if there is a better way it will like have to be a different revamped UI. I think I'll merge this for now.

@PVince81 PVince81 merged commit cc8cc1a into master Apr 7, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer No new issues
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the privatelink branch Apr 7, 2017

@felixheidecke

This comment has been minimized.

Show comment
Hide comment
@felixheidecke

felixheidecke Apr 7, 2017

Contributor

7e419d4a-1b81-11e7-8ec6-fa7ab1b4175f

Still a double wording?! Public-Link people have "access" too but can't use it ;-)
We can only hope people will understand what that really means. If they do is a whole other thing.
I'm fine with it, but it's not optimal.

Contributor

felixheidecke commented Apr 7, 2017

7e419d4a-1b81-11e7-8ec6-fa7ab1b4175f

Still a double wording?! Public-Link people have "access" too but can't use it ;-)
We can only hope people will understand what that really means. If they do is a whole other thing.
I'm fine with it, but it's not optimal.

@pmaier1

This comment has been minimized.

Show comment
Hide comment
@pmaier1

pmaier1 Apr 7, 2017

Contributor

Public-Link people have "access" too but can't use it ;-)

This does not make sense or at least I don't understand it^^

There are two use cases for the private link:

  1. Have a link to a certain file/folder that will stay as it is as long as the file is available (this is why I described it as 'permanent')
  2. Point others to certain files/folders within shares

I'm also not totally happy with it but I don't know how we could make it more clear :/

Contributor

pmaier1 commented Apr 7, 2017

Public-Link people have "access" too but can't use it ;-)

This does not make sense or at least I don't understand it^^

There are two use cases for the private link:

  1. Have a link to a certain file/folder that will stay as it is as long as the file is available (this is why I described it as 'permanent')
  2. Point others to certain files/folders within shares

I'm also not totally happy with it but I don't know how we could make it more clear :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment