New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed example theme to `theme-example` like suggested in our documentation #27632

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
3 participants
@phisch
Contributor

phisch commented Apr 12, 2017

Description

Renamed the theme directory and app name in info.xml because of: https://doc.owncloud.org/server/10.0/developer_manual/core/theming.html#appinfo-info-xml

Related Issue

#27268 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phisch phisch requested a review from PVince81 Apr 12, 2017

@phisch

This comment has been minimized.

Show comment
Hide comment
@phisch

phisch Apr 12, 2017

Contributor

Git hickup... commits delete, but not rename.
edit: was because of the gitignore

Contributor

phisch commented Apr 12, 2017

Git hickup... commits delete, but not rename.
edit: was because of the gitignore

@PVince81 PVince81 added this to the 10.0 milestone Apr 18, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 18, 2017

Member

rebased for CI

Member

PVince81 commented Apr 18, 2017

rebased for CI

@PVince81 PVince81 modified the milestones: 10.0.1, 10.0 Apr 26, 2017

renamed example theme to `theme-example` like suggested in our docume…
…ntation

example-theme is now theme-example thus updating the gitignore

re-adding theme, because it committed as deleted because of the gitignore

@DeepDiver1975 DeepDiver1975 self-requested a review May 4, 2017

@DeepDiver1975

Squashed the commits ....

@DeepDiver1975 DeepDiver1975 merged commit 9b3f5f1 into master May 4, 2017

1 of 4 checks passed

Scrutinizer Running
Details
continuous-integration/jenkins/pr-head This commit is scheduled to be built
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the rename-theme branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment