New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don´t change folders with --repair-filecache #27668

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
3 participants
@Rello
Contributor

Rello commented Apr 18, 2017

Description

check if folder is "httpd/unix-directory" and don´t perform --repair-filecache there

Related Issue

  • #27585
  • create a folder "WAV"
  • check filecache: mimetype 1 (unix directory)
  • execute occ maintenance:mimetype:update-db --repair-filecache
  • check filecache: mimetype "audio/wav"

Motivation and Context

How Has This Been Tested?

WAV folder is not changed anymore

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
don´t change folders with --repair-filecache
check if folder is "httpd/unix-directory" and don´t perform here #27585
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Apr 18, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Apr 18, 2017

CLA assistant check
All committers have signed the CLA.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 4, 2017

Member

👍 thanks

Member

PVince81 commented May 4, 2017

👍 thanks

@PVince81 PVince81 merged commit 0b3966e into owncloud:master May 4, 2017

4 checks passed

Scrutinizer 2 new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is not signed yet.
Details
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 6, 2017

Member

Turns out that having the wrong mime type for folders can be dangerous when doing MOVE operations, as the MOVE would not move the child entries since it believes the main entry is not a folder.

Let's backport this down to stable9.

cc @tomneedham @jvillafanez

Member

PVince81 commented Jul 6, 2017

Turns out that having the wrong mime type for folders can be dangerous when doing MOVE operations, as the MOVE would not move the child entries since it believes the main entry is not a folder.

Let's backport this down to stable9.

cc @tomneedham @jvillafanez

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 6, 2017

Member

stable9.1: #28326
stable9: #28327

Member

PVince81 commented Jul 6, 2017

stable9.1: #28326
stable9: #28327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment