New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Cron settings: support themed radio buttons #27681

Merged
merged 1 commit into from Apr 20, 2017

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Apr 19, 2017

Because of this, themes can be applied too.

Description

Add class to support the :before CSS part. This will allow theming, and shows the new OC radio buttons.

Related Issue

Unknown

Motivation and Context

Comply with standard. Forgotten part, I guess.

How Has This Been Tested?

Apply commit, watch and see. Tested in OC9 and OC10.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Suggestion

Replace e.g. all
input[type="radio"].radio:checked + label:before
by
input[type="radio"]:checked + label:before
so these edits aren't needed. It's redundant anyway, since all vanilla theming (default OC theming) should be applied to all radio buttons and check boxes.

Fallon Turner
Admin Cron settings: support themes radio buttons
Because of this, themes can be applied too.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone Apr 20, 2017

@DeepDiver1975 DeepDiver1975 requested a review from tomneedham Apr 20, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 20, 2017

Member

Fine by me for now, but I'm not sure everyone will think about setting the "radio" class on all new radio elements.

Member

PVince81 commented Apr 20, 2017

Fine by me for now, but I'm not sure everyone will think about setting the "radio" class on all new radio elements.

@PVince81 PVince81 merged commit 718d85b into owncloud:master Apr 20, 2017

3 of 4 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Scrutinizer 2 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 24, 2017

Which is why

input[type="radio"].radio:checked + label:before

should be replaced in you big styles.css or input.css by

input[type="radio"]:checked + label:before

And so on.

ghost commented Apr 24, 2017

Which is why

input[type="radio"].radio:checked + label:before

should be replaced in you big styles.css or input.css by

input[type="radio"]:checked + label:before

And so on.

@ghost ghost deleted the patch-4 branch Apr 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment