Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sharing subtab headers if no link share is allowed #27708

Merged
merged 1 commit into from
May 4, 2017
Merged

Remove sharing subtab headers if no link share is allowed #27708

merged 1 commit into from
May 4, 2017

Conversation

PVince81
Copy link
Contributor

Description

Because then there is only one tab to select, so only keep its body.

Related Issue

None (I thought there was one but can't find it any more)

Motivation and Context

It looks bad to have an empty "Public link" subtab.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felixheidecke please review

@PVince81 PVince81 added this to the 10.0.1 milestone Apr 20, 2017
Remove sharing subtab headers if no link share is allowed
64852b2 
Because then there is only one tab to select, so only keep its body.
@PVince81 PVince81 force-pushed the share-nolink-removesubtab branch from fbb1254 to 64852b2 Compare May 4, 2017 09:27
@PVince81
Copy link
Contributor Author

PVince81 commented May 4, 2017

Tested as follows:

  1. Go to admin page and disallow link sharing
  2. Open the share panel in files view
  3. See that no subtabs appear and the panel displays the user share panel

@felixheidecke @tomneedham @VicDeo please review

@DeepDiver1975 DeepDiver1975 self-requested a review May 4, 2017 10:09
@DeepDiver1975 DeepDiver1975 merged commit 819a757 into master May 4, 2017
@DeepDiver1975 DeepDiver1975 deleted the share-nolink-removesubtab branch May 4, 2017 10:10
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@PVince81 @DeepDiver1975