New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill RemoveOldShares #27737

Merged
merged 1 commit into from May 4, 2017

Conversation

Projects
None yet
3 participants
@DeepDiver1975
Member

DeepDiver1975 commented Apr 24, 2017

Description

馃拃

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0 milestone Apr 24, 2017

@DeepDiver1975 DeepDiver1975 requested a review from PVince81 Apr 24, 2017

@PVince81 PVince81 modified the milestones: 10.0.1, 10.0 Apr 25, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 25, 2017

Member

10.0.1. Only criticals from now on.

JS tests timed out.

Member

PVince81 commented Apr 25, 2017

10.0.1. Only criticals from now on.

JS tests timed out.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Apr 25, 2017

Member

馃憤

To merge after 10.0.0 is out.

Member

PVince81 commented Apr 25, 2017

馃憤

To merge after 10.0.0 is out.

@DeepDiver1975

Printing out the log before behat execution?

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG Apr 27, 2017

Member

Removed last commits, they were just for debugging. Being addressed here #27749

This PR will require a rebase after that one is fixed in master.

Member

SergioBertolinSG commented Apr 27, 2017

Removed last commits, they were just for debugging. Being addressed here #27749

This PR will require a rebase after that one is fixed in master.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 4, 2017

Member

Rebased for CI

Member

PVince81 commented May 4, 2017

Rebased for CI

@PVince81 PVince81 merged commit 7ceef9c into master May 4, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the kill-oc90-repair-steps branch May 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment