New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed output in error pages #27808

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
3 participants
@peterprochaska
Contributor

peterprochaska commented May 4, 2017

Description

Escape output in error pages

Related Issue

fixes #27807

Motivation and Context

Now downloading files or folder with quotes is possible

How Has This Been Tested?

Download File with quotes and there is no error page

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 self-requested a review May 4, 2017

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 4, 2017

Show outdated Hide outdated lib/private/legacy/template.php
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 4, 2017

Member

Code looks good. How did you test the error page ?

I tried testing the error page as well but the file name doesn't even appear there... Maybe it did in older versions.

download-error

Member

PVince81 commented May 4, 2017

Code looks good. How did you test the error page ?

I tried testing the error page as well but the file name doesn't even appear there... Maybe it did in older versions.

download-error

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 4, 2017

Member

👍 if CI passes

Member

PVince81 commented May 4, 2017

👍 if CI passes

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 4, 2017

Member

@Peter-Prochaska please always link to the backports in the original PR and back. Without this it makes it very difficult to track.

Member

PVince81 commented May 4, 2017

@Peter-Prochaska please always link to the backports in the original PR and back. Without this it makes it very difficult to track.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 12, 2017

Member

CI stalled, @DeepDiver1975 please restart

Member

PVince81 commented May 12, 2017

CI stalled, @DeepDiver1975 please restart

@DeepDiver1975 DeepDiver1975 merged commit ae31dbe into master May 15, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the fixed-error-page-output branch May 15, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 15, 2017

Member

regression: #28684

Member

PVince81 commented Aug 15, 2017

regression: #28684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment