New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permanent link share privacy warning #27844

Merged
merged 2 commits into from May 12, 2017

Conversation

Projects
None yet
4 participants
@PVince81
Member

PVince81 commented May 9, 2017

Description

Add permanent link share privacy warning in the share tab view.

Related Issue

owncloud/enterprise#1914

Motivation and Context

Some people want it

How Has This Been Tested?

Open the public link section in the share tab in the sidebar

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 PVince81 added this to the 10.0.1 milestone May 9, 2017

@PVince81 PVince81 requested review from felixheidecke and pmaier1 May 9, 2017

@pmaier1

pmaier1 approved these changes May 9, 2017

In the clients there is no 'Warning: ' so for consistency I removed it.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 10, 2017

Member

rebased for CI

Member

PVince81 commented May 10, 2017

rebased for CI

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 12, 2017

Member

So who is going to give a little thumbs up to this ?

Member

PVince81 commented May 12, 2017

So who is going to give a little thumbs up to this ?

PVince81 and others added some commits May 9, 2017

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 12, 2017

Contributor

👍 WFM A warning 'Anyone with the link has access to the file/folder' appears after reloading

Contributor

davitol commented May 12, 2017

👍 WFM A warning 'Anyone with the link has access to the file/folder' appears after reloading

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975
Member

DeepDiver1975 commented May 12, 2017

👍

@DeepDiver1975 DeepDiver1975 merged commit 343a3ed into master May 12, 2017

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the share-link-warning branch May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment