New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return false if the stat doesn't find the file #27859

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
3 participants
@jvillafanez
Member

jvillafanez commented May 11, 2017

Description

return false instead of throwing an exception if the file isn't found

Related Issue

owncloud/windows_network_drive#99

Motivation and Context

The stat function might fail because the file doesn't exists. In this case, the expectation should be to return false instead throwing an exception

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 @DeepDiver1975

@jvillafanez jvillafanez added this to the 10.0.1 milestone May 11, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 11, 2017

Member

Makes sense 👍

I'm surprised we didn't find this earlier.

Member

PVince81 commented May 11, 2017

Makes sense 👍

I'm surprised we didn't find this earlier.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 11, 2017

Member

please rebase to rerun the Jenkins lottery, you might win!

Member

PVince81 commented May 11, 2017

please rebase to rerun the Jenkins lottery, you might win!

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 12, 2017

Member

Oracle...

Member

PVince81 commented May 12, 2017

Oracle...

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 12, 2017

Member

please rebase again

Member

PVince81 commented May 12, 2017

please rebase again

@jvillafanez

This comment has been minimized.

Show comment
Hide comment
@jvillafanez

jvillafanez May 15, 2017

Member

rebased

Member

jvillafanez commented May 15, 2017

rebased

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

Failure expected, see #27888

Merging

Member

PVince81 commented May 15, 2017

Failure expected, see #27888

Merging

@PVince81 PVince81 merged commit a8dab2f into master May 15, 2017

3 of 6 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
continuous-integration/styleci/pr The StyleCI analysis has failed - 1 file needs addressing
Details
continuous-integration/styleci/push The StyleCI analysis is running
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the fix_stat_when_not_found branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment