New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to restrict share autocomplete to group members #27869

Merged
merged 4 commits into from May 15, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 12, 2017

Description

When set, the autocomplete only displays user or group results matching
the current user's group memberships.

Typing a full user or group name not in the result list will still allow
sharing with these entries.

Related Issue

Fixes #27849

Motivation and Context

See issue

How Has This Been Tested?

When the new option is set:

  • TEST: autocomplete only show current user's user results
  • TEST: autocomplete only show current user's group results
  • TEST: typing full recipient user name not in result list still allows sharing
  • TEST: typing full recipient group name not in result list still allows sharing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

TODOs:

  • beware of potential conflict with #27832, might need rebase/retesting after that one
  • add unit tests
  • add integration tests

@jvillafanez @tomneedham @pmaier1

@felixboehm

This comment has been minimized.

Show comment
Hide comment
@felixboehm

felixboehm May 12, 2017

Contributor

👍 Code looks good.

Contributor

felixboehm commented May 12, 2017

👍 Code looks good.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 12, 2017

Member

Tests added. Turns out we already had sharee tests so it was much easier to add new ones.

I suggest we merge this. Once @tomneedham rebases #27832 the integration tests will tell whether this still works with his changes.

Member

PVince81 commented May 12, 2017

Tests added. Turns out we already had sharee tests so it was much easier to add new ones.

I suggest we merge this. Once @tomneedham rebases #27832 the integration tests will tell whether this still works with his changes.

PVince81 added some commits May 12, 2017

Add option to restrict share autocomplete to group members
When set, the autocomplete only displays user or group results matching
the current user's group memberships.

Typing a full user or group name not in the result list will still allow
sharing with these entries.
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

rebased for CI

Member

PVince81 commented May 15, 2017

rebased for CI

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

Test Result (1 failure )
sharing.Increasing permissions is allowed for owner

11:44:52 /var/lib/jenkins/workspace/owncloud-core_core_PR-27869-PFEZRZD5FK7SZH2ETSWIQLOH5DH7VH6KYURTFPNPUUQEXLM2E42A/tests/integration/features/sharing-v1.feature:1051

Uh oh

Member

PVince81 commented May 15, 2017

Test Result (1 failure )
sharing.Increasing permissions is allowed for owner

11:44:52 /var/lib/jenkins/workspace/owncloud-core_core_PR-27869-PFEZRZD5FK7SZH2ETSWIQLOH5DH7VH6KYURTFPNPUUQEXLM2E42A/tests/integration/features/sharing-v1.feature:1051

Uh oh

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

UH OH!! This fails on master as well 😱

I'll have a look...

Member

PVince81 commented May 15, 2017

UH OH!! This fails on master as well 😱

I'll have a look...

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

this PR fixes the test issue from master: #27888

Member

PVince81 commented May 15, 2017

this PR fixes the test issue from master: #27888

@PVince81 PVince81 merged commit 347264c into master May 15, 2017

3 of 6 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
continuous-integration/styleci/push The StyleCI analysis was misconfigured
Details
continuous-integration/styleci/pr The StyleCI analysis has failed - 5 files need addressing
Details
Scrutinizer 1 new issues, 2 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the restrict-autocomplete-groups branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment