New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jquery.fileupload.js to v9.18.0 #27875

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
5 participants
@VicDeo
Member

VicDeo commented May 12, 2017

Description

Update blueimp/jQuery-File-Upload to v9.18.0 instead of smth dated Aug 2, 2013

Related Issue

Fixes #27830

Motivation and Context

No more data corruption while uploading files with IE

How Has This Been Tested?

  1. Upload
  2. Download
  3. Compare

Testing in progress. Tested with Chrome and IE11 by now

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the 10.0.1 milestone May 12, 2017

@VicDeo VicDeo requested a review from PVince81 May 12, 2017

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo May 12, 2017

Member

@jimk85 would you mind testing?

Member

VicDeo commented May 12, 2017

@jimk85 would you mind testing?

@jimk85

This comment has been minimized.

Show comment
Hide comment
@jimk85

jimk85 May 13, 2017

@VicDeo I'm sorry, that's something new for me. How do I perform the test?
Should I change the old fileupload.js in the core against the in the post?

jimk85 commented May 13, 2017

@VicDeo I'm sorry, that's something new for me. How do I perform the test?
Should I change the old fileupload.js in the core against the in the post?

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo

VicDeo May 13, 2017

Member

@jimk85 yes, you can just download it here https://github.com/owncloud/core/raw/82ac394c9c18982aa2f6c003cf69c637f475ecf6/apps/files/js/jquery.fileupload.js
and replace apps/files/js/jquery.fileupload.js with the downloaded file.

Member

VicDeo commented May 13, 2017

@jimk85 yes, you can just download it here https://github.com/owncloud/core/raw/82ac394c9c18982aa2f6c003cf69c637f475ecf6/apps/files/js/jquery.fileupload.js
and replace apps/files/js/jquery.fileupload.js with the downloaded file.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 13, 2017

Member

Great!

Stuff to retest for regressions:

  • Upload single file with file picker
  • Upload multiple files with file picker
  • Upload single file with drag and drop
  • Upload multiple files with drag and drop
  • Upload folder with drag and drop (Chrome only)
  • Progress bar must still work
  • Cancel upload from progress bar
    ⚠️ make sure to verify the uploaded files by downloading and checking md5!

Browsers:

  • IE11
  • Safari (latest?)
  • Chrome
  • Firefox

Bonus:

  • check if this also fixes #19834 and if it does, close it 😄

@owncloud/qa

Member

PVince81 commented May 13, 2017

Great!

Stuff to retest for regressions:

  • Upload single file with file picker
  • Upload multiple files with file picker
  • Upload single file with drag and drop
  • Upload multiple files with drag and drop
  • Upload folder with drag and drop (Chrome only)
  • Progress bar must still work
  • Cancel upload from progress bar
    ⚠️ make sure to verify the uploaded files by downloading and checking md5!

Browsers:

  • IE11
  • Safari (latest?)
  • Chrome
  • Firefox

Bonus:

  • check if this also fixes #19834 and if it does, close it 😄

@owncloud/qa

@jimk85

This comment has been minimized.

Show comment
Hide comment
@jimk85

jimk85 May 13, 2017

  • Upload single file with file picker --> Worked with IE11 and Chrome
  • Upload multiple files with file picker --> Worked with IE11 and Chrome
  • Upload single file with drag and drop --> Worked with IE11 and Chrome
  • Upload multiple files with drag and drop --> Worked with IE11 and Chrome
  • Upload folder with drag and drop (Chrome only) --> Worked
  • Progress bar must still work --> Worked
  • Cancel upload from progress bar --> Worked with Chrome, but IE11 not realy (Browser: Website does not respond)

jimk85 commented May 13, 2017

  • Upload single file with file picker --> Worked with IE11 and Chrome
  • Upload multiple files with file picker --> Worked with IE11 and Chrome
  • Upload single file with drag and drop --> Worked with IE11 and Chrome
  • Upload multiple files with drag and drop --> Worked with IE11 and Chrome
  • Upload folder with drag and drop (Chrome only) --> Worked
  • Progress bar must still work --> Worked
  • Cancel upload from progress bar --> Worked with Chrome, but IE11 not realy (Browser: Website does not respond)
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

not sure if cancelling in IE11 ever worked before...

Member

PVince81 commented May 15, 2017

not sure if cancelling in IE11 ever worked before...

@jimk85

This comment has been minimized.

Show comment
Hide comment
@jimk85

jimk85 May 15, 2017

Okay... I'm also not sure because I personally do not use IE. :)
Nevertheless, I thank you for your great support!!!

Can I close the ticket?

jimk85 commented May 15, 2017

Okay... I'm also not sure because I personally do not use IE. :)
Nevertheless, I thank you for your great support!!!

Can I close the ticket?

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

We'll close the ticket after this PR is merged. Someone else still need to test with Safari, etc.
Thanks for your help!

Member

PVince81 commented May 15, 2017

We'll close the ticket after this PR is merged. Someone else still need to test with Safari, etc.
Thanks for your help!

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

@davitol please test safari and firefox as discussed, thanks

Member

PVince81 commented May 15, 2017

@davitol please test safari and firefox as discussed, thanks

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 15, 2017

Contributor
  • Upload single file with file picker --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Upload multiple files with file picker --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Upload single file with drag and drop --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Upload multiple files with drag and drop --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Progress bar must still work --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Cancel upload from progress bar --> Worked with Safari Version 9.1.2 (10601.7.7)
Contributor

davitol commented May 15, 2017

  • Upload single file with file picker --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Upload multiple files with file picker --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Upload single file with drag and drop --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Upload multiple files with drag and drop --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Progress bar must still work --> Worked with Safari Version 9.1.2 (10601.7.7)
  • Cancel upload from progress bar --> Worked with Safari Version 9.1.2 (10601.7.7)
@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 15, 2017

Contributor
  • Upload single file with file picker --> Worked with Firefox 53.0.2 (64-bit)
  • Upload multiple files with file picker --> Worked with Firefox 53.0.2 (64-bit)
  • Upload single file with drag and drop --> Worked with Firefox 53.0.2 (64-bit)
  • Upload multiple files with drag and drop --> Worked with Firefox 53.0.2 (64-bit)
  • Progress bar must still work --> Worked with Firefox 53.0.2 (64-bit)
  • Cancel upload from progress bar --> Worked with Firefox 53.0.2 (64-bit)
Contributor

davitol commented May 15, 2017

  • Upload single file with file picker --> Worked with Firefox 53.0.2 (64-bit)
  • Upload multiple files with file picker --> Worked with Firefox 53.0.2 (64-bit)
  • Upload single file with drag and drop --> Worked with Firefox 53.0.2 (64-bit)
  • Upload multiple files with drag and drop --> Worked with Firefox 53.0.2 (64-bit)
  • Progress bar must still work --> Worked with Firefox 53.0.2 (64-bit)
  • Cancel upload from progress bar --> Worked with Firefox 53.0.2 (64-bit)
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

enough CI massage today already... ran JS test locally, they passed... merging

Member

PVince81 commented May 15, 2017

enough CI massage today already... ran JS test locally, they passed... merging

@PVince81 PVince81 merged commit 0cf5a2a into master May 15, 2017

3 of 4 checks passed

continuous-integration/styleci/push The StyleCI analysis was misconfigured
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the fix-27830 branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment