New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for password validation #27883

Merged
merged 2 commits into from May 16, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 15, 2017

Description

Makes it possible for apps to implement validation.
Also added code to properly throw exceptions and convert them into
messages to display in the UI.

Related Issue

Motivation and Context

To allow for password policies

How Has This Been Tested?

With a quick test app, throw an exception in the hooks and check that the message is properly displayed in the following cases:

  • TEST: when setting a password in the link share dialog
  • TEST: when a user sets a password in the personal page
  • TEST: when a user sets a password after password reset
  • TEST: when an admin sets a password in the users page
  • TEST: when creating a user with OCC: occ user:add user1
  • TEST: when resetting a password with OCC occ user:resetpassword user1
  • TEST: when creating a user with provisioning API: curl -X POST --user admin:admin "http://localhost/owncloud/ocs/v1.php/cloud/users" -d userid="userx" -d password="y"
  • TEST: when setting a password with provisioning API: curl -X PUT --user admin:admin "http://localhost/owncloud/ocs/v1.php/cloud/users/user1" -d key="password" -d value="x"

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975

@PVince81 PVince81 added this to the 10.0.1 milestone May 15, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

All test cases work now, please review @DeepDiver1975 @tomneedham @VicDeo

Member

PVince81 commented May 15, 2017

All test cases work now, please review @DeepDiver1975 @tomneedham @VicDeo

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975
Member

DeepDiver1975 commented May 15, 2017

bildschirmfoto von 2017-05-15 13-28-37

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

One does not simply... ok I'll have a look

Member

PVince81 commented May 15, 2017

One does not simply... ok I'll have a look

PVince81 added some commits May 15, 2017

Add events for password validation
Makes it possible for apps to implement validation.
Also added code to properly throw exceptions and convert them into
messages to display in the UI.
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

Rebased for CI, please recheck

Member

PVince81 commented May 15, 2017

Rebased for CI, please recheck

@DeepDiver1975 DeepDiver1975 self-requested a review May 16, 2017

@DeepDiver1975 DeepDiver1975 merged commit 478b889 into master May 16, 2017

4 checks passed

Scrutinizer 4 new issues, 7 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the validate-password-events branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment