New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow app to register multiple settings panels of same type #27885

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
3 participants
@tomneedham
Member

tomneedham commented May 15, 2017

Description

Apps can now register multiple settings panels of the same type

How Has This Been Tested?

  • With an app and unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tomneedham tomneedham added this to the 10.0.1 milestone May 15, 2017

@tomneedham tomneedham self-assigned this May 15, 2017

@tomneedham tomneedham requested a review from davitol May 15, 2017

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 15, 2017

Contributor

👍 WFM

Contributor

davitol commented May 15, 2017

👍 WFM

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 15, 2017

Member

expected failure: #27888

Member

PVince81 commented May 15, 2017

expected failure: #27888

@PVince81 PVince81 merged commit aaba0b5 into master May 15, 2017

3 of 4 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Scrutinizer 3 new issues, 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the allow-multiple-settings-panels-per-app branch May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment