New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically focus the password reset field #27889

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 15, 2017

Description

Saves some clicking...

Related Issue

Motivation and Context

How Has This Been Tested?

Set email address.
Trigger password reset.
Receive email with link.
Open link.

Before fix: need to click the password field.
After fix: no mouse required! the field is autofocussed!!!111

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pmaier1 @DeepDiver1975 @IljaN @felixheidecke

@PVince81 PVince81 added this to the 10.0.1 milestone May 15, 2017

@DeepDiver1975 DeepDiver1975 self-requested a review May 16, 2017

@DeepDiver1975 DeepDiver1975 merged commit c520677 into master May 16, 2017

3 of 4 checks passed

continuous-integration/jenkins/pr-head This commit cannot be built
Details
Scrutinizer 3 new issues, 3 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the pwreset-autofocus branch May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment