New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9.1] Proper separation of quota values in APIs #27896

Merged
merged 2 commits into from May 17, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 16, 2017

Backport of #27895 to stable9.1

@jvillafanez please evaluate if LDAP is affected here too.

@DeepDiver1975

@PVince81 PVince81 added this to the 9.1.6 milestone May 16, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 16, 2017

Member

Set default quota to 5 GB

  • TEST: newly created user gets "default" quota, properly applies in personal page, 5 GB
  • TEST: set existing user quota to "default", properly applies in personal page, 5 GB
  • TEST: set existing user quota to "unlimited", properly applies in personal page (unlimited)
  • TEST: set existing user quota to "1 GB", properly applies in personal page, 1 GB
Member

PVince81 commented May 16, 2017

Set default quota to 5 GB

  • TEST: newly created user gets "default" quota, properly applies in personal page, 5 GB
  • TEST: set existing user quota to "default", properly applies in personal page, 5 GB
  • TEST: set existing user quota to "unlimited", properly applies in personal page (unlimited)
  • TEST: set existing user quota to "1 GB", properly applies in personal page, 1 GB

@PVince81 PVince81 referenced this pull request May 16, 2017

Merged

Proper separation of quota values in APIs #27895

3 of 9 tasks complete
@jvillafanez

This comment has been minimized.

Show comment
Hide comment
@jvillafanez
Member

jvillafanez commented May 17, 2017

👍

PVince81 added some commits May 15, 2017

Proper separation of quota values in APIs
User::getQuota() and User::setQuota() are now reading the exact value as
set in the database instead of interpreting it. This is how it used to
behave.

Util::getUserQuota() is the method that interprets the quota for example
by replacing a default value with the default quota value from the app
config.

@PVince81 PVince81 merged commit 6a6ca83 into stable9.1 May 17, 2017

3 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the stable9.1-fixdefaultquota branch May 17, 2017

@PVince81 PVince81 referenced this pull request Jul 5, 2017

Merged

[stable9] Fix default quota #28302

4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment