New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swiftmailer #27897

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
4 participants
@DeepDiver1975
Member

DeepDiver1975 commented May 16, 2017

Description

Related Issue

fixes #26886

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 16, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 16, 2017

Member

missing list of test cases, did you retest emailing ?

Member

PVince81 commented May 16, 2017

missing list of test cases, did you retest emailing ?

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 May 16, 2017

Member

missing list of test cases, did you retest emailing ?

is the mailhog integratoin test already in place? I dont have email setup in my dev env .... maybe I should ....

Member

DeepDiver1975 commented May 16, 2017

missing list of test cases, did you retest emailing ?

is the mailhog integratoin test already in place? I dont have email setup in my dev env .... maybe I should ....

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 16, 2017

Member

Mailhog was only quickly added for use in guest apps. No tests were added for core mailing yet.

cc @SergioBertolinSG

Member

PVince81 commented May 16, 2017

Mailhog was only quickly added for use in guest apps. No tests were added for core mailing yet.

cc @SergioBertolinSG

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG May 16, 2017

Member

Mailhog was only quickly added for use in guest apps. No tests were added for core mailing yet.

Yes that's right, in core it will require to spawn the mailhog container like in guest app and actually write the tests. I guess some of them will require to use the ajax request from the ui, like in guests.

Member

SergioBertolinSG commented May 16, 2017

Mailhog was only quickly added for use in guest apps. No tests were added for core mailing yet.

Yes that's right, in core it will require to spawn the mailhog container like in guest app and actually write the tests. I guess some of them will require to use the ajax request from the ui, like in guests.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 16, 2017

Member

I suggest quick manual testing for now. Maybe test an activity mail and a guest mail.

Member

PVince81 commented May 16, 2017

I suggest quick manual testing for now. Maybe test an activity mail and a guest mail.

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 May 16, 2017

Member

Tested

  • password change
  • smtp test email

bildschirmfoto von 2017-05-16 15-34-19

Member

DeepDiver1975 commented May 16, 2017

Tested

  • password change
  • smtp test email

bildschirmfoto von 2017-05-16 15-34-19

@PVince81 PVince81 merged commit c142369 into master May 16, 2017

4 checks passed

Scrutinizer 4 new issues, 5 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the update-swift branch May 16, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 16, 2017

Member

Thanks 👍

Member

PVince81 commented May 16, 2017

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment