New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not verify email address for admins #27921

Merged
merged 1 commit into from May 17, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 17, 2017

Description

Do not verify email address for admins.
For non-admins, send the email verification mail.

Related Issue

Fixes #27916

Motivation and Context

See ticket, solves confusion.

How Has This Been Tested?

  • TEST: set email as admin, set directly
  • TEST: set email as regular user, email gets sent

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 merged commit c4173b3 into master May 17, 2017

4 checks passed

Scrutinizer 1720 Issues, 166 Patches
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the dont-verify-admin-email branch May 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment