New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default permissions for link shares #27927

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 18, 2017

Description

When no public upload is allowed, one should still be able to create
link shares with neither "permissions" nor "publicUpload" parameters
given.

Related Issue

Fixes #27922

Motivation and Context

It was a problem with the original implementation, a condition was wrong.

How Has This Been Tested?

curl, integration test, unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please review @jvillafanez @VicDeo @tomneedham @DeepDiver1975 @IljaN

Fix default permissions for link shares
When no public upload is allowed, one should still be able to create
link shares with neither "permissions" nor "publicUpload" parameters
given.
@jesmrec

This comment has been minimized.

Show comment
Hide comment
@jesmrec

jesmrec commented May 18, 2017

@PVince81 fixed 👍

@PVince81 PVince81 merged commit 9ee7242 into master May 18, 2017

4 checks passed

Scrutinizer 5 new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the linkshare-fixdefaultperms branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment