New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton files are now copied on for shibboleth users #27935

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
4 participants
@DeepDiver1975
Member

DeepDiver1975 commented May 18, 2017

Description

Related Issue

How Has This Been Tested?

  • connect owncloud with testshib.org
  • login via testshib.org
  • see if skeleton files appear or not

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 18, 2017

@DeepDiver1975 DeepDiver1975 requested review from butonic and davitol May 18, 2017

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 19, 2017

Contributor

👍 Tested and WFM

Contributor

davitol commented May 19, 2017

👍 Tested and WFM

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

please verify that skeleton still works for other scenarios:

  • regular home
  • alternative home
  • object store home (if it ever worked before...)
Member

PVince81 commented May 19, 2017

please verify that skeleton still works for other scenarios:

  • regular home
  • alternative home
  • object store home (if it ever worked before...)
@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic May 19, 2017

Member
  • regular home
  • home folder naming rule set to mail, skeleton copied to data/
  • autoprovisioned users
  • objectstore ... need to check other saml stuff first
Member

butonic commented May 19, 2017

  • regular home
  • home folder naming rule set to mail, skeleton copied to data/
  • autoprovisioned users
  • objectstore ... need to check other saml stuff first
@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

can't test objectstore, app is broken: owncloud/objectstore#56

maybe use the workaround ? ironically the bug itself is related to admin home folder not automatically setup.

Member

PVince81 commented May 19, 2017

can't test objectstore, app is broken: owncloud/objectstore#56

maybe use the workaround ? ironically the bug itself is related to admin home folder not automatically setup.

@davitol

This comment has been minimized.

Show comment
Hide comment
@davitol

davitol May 19, 2017

Contributor

Objectstore:

  1. Apply this PR
  2. Create a new user

The user is created and the Skeleton files appears

Contributor

davitol commented May 19, 2017

Objectstore:

  1. Apply this PR
  2. Create a new user

The user is created and the Skeleton files appears

@PVince81 PVince81 merged commit b99aa22 into master May 19, 2017

4 checks passed

Scrutinizer 2 new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the fix-copySkeleton-for-shib branch May 19, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

Thanks!

Member

PVince81 commented May 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment