Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton files are now copied on for shibboleth users #27935

Merged
merged 1 commit into from May 19, 2017

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 18, 2017

Description

Related Issue

How Has This Been Tested?

  • connect owncloud with testshib.org
  • login via testshib.org
  • see if skeleton files appear or not

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davitol
Copy link
Contributor

davitol commented May 19, 2017

👍 Tested and WFM

@PVince81
Copy link
Contributor

please verify that skeleton still works for other scenarios:

  • regular home
  • alternative home
  • object store home (if it ever worked before...)

@butonic
Copy link
Member

butonic commented May 19, 2017

  • regular home
  • home folder naming rule set to mail, skeleton copied to data/
  • autoprovisioned users
  • objectstore ... need to check other saml stuff first

@PVince81
Copy link
Contributor

can't test objectstore, app is broken: https://github.com/owncloud/objectstore/issues/56

maybe use the workaround ? ironically the bug itself is related to admin home folder not automatically setup.

@davitol
Copy link
Contributor

davitol commented May 19, 2017

Objectstore:

  1. Apply this PR
  2. Create a new user

The user is created and the Skeleton files appears

@PVince81 PVince81 merged commit b99aa22 into master May 19, 2017
@PVince81 PVince81 deleted the fix-copySkeleton-for-shib branch May 19, 2017 14:22
@PVince81
Copy link
Contributor

Thanks!

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants