New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cached app info before installing an app #27953

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
3 participants
@DeepDiver1975
Member

DeepDiver1975 commented May 19, 2017

Related Issue

fixes #27949

How Has This Been Tested?

  • install texteditor via market app
  • double check the version as printed in console of ./occ a:l

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 19, 2017

@DeepDiver1975 DeepDiver1975 requested a review from PVince81 May 19, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

Tested, works and code makes sense 👍

Member

PVince81 commented May 19, 2017

Tested, works and code makes sense 👍

@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic May 19, 2017

Member

👍 works!

➜  owncloud-9.1-10x patch -p1 < 27953.diff
patching file lib/private/App/AppManager.php
patching file lib/private/Installer.php
patching file lib/private/legacy/app.php
➜  owncloud-9.1-10x sudo -u www-data php /var/www/oc/owncloud-9.1-10x/occ upgrade 
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Turned on maintenance mode
Updating database schema
Updated database
Updating <files_pdfviewer> ...
Updated <files_pdfviewer> to 0.8.2
Updating <files_texteditor> ...
Updated <files_texteditor> to 2.2
Updating <gallery> ...
Updated <gallery> to 16.0.2
Updating <user_ldap> ...
Updated <user_ldap> to 0.9.0.1
Updating <activity> ...
Updating <dav> ...
Updated <dav> to 0.2.9
Drop old database tables

 Done
 28/28 [============================] 100%
Fix permissions so avatars can be stored again
 Done
 2/2 [============================] 100%
Move user avatars outside the homes to the new location
 Done
 1/1 [============================] 100%
Starting code integrity check...
Finished code integrity check
Update successful
Turned off maintenance mode
Reset log level
➜  owncloud-9.1-10x sudo -u www-data php /var/www/oc/owncloud-9.1-10x/occ app:list
Enabled:
  - activity: 2.3.4
  - admin_audit: 0.7
  - comments: 0.3.0
  - configreport: 0.1.1
  - dav: 0.2.9
  - enterprise_key: 0.1.0
  - federatedfilesharing: 0.3.0
  - federation: 0.1.0
  - files: 1.5.1
  - files_external: 0.7.0
  - files_pdfviewer: 0.8.2
  - files_sharing: 0.10.0
  - files_texteditor: 2.2
  - files_trashbin: 0.9.0
  - files_versions: 1.3.0
  - files_videoplayer: 0.9.8
  - firewall: 2.4.0
  - firstrunwizard: 1.1
  - gallery: 16.0.2
  - market: 0.1.0
  - notifications: 0.3.0
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - systemtags_management: 0.2.0
  - templateeditor: 0.1
  - theme-enterprise: 1.0.0
  - updatenotification: 0.2.1
  - user_ldap: 0.9.0.1
  - windows_network_drive: 0.6.0
  - workflow: 0.2.3
Disabled:
  - announcementcenter
  - encryption
  - external
  - files_antivirus
  - files_ldap_home
  - objectstore
  - password_policy
  - sharepoint
  - theme-example
  - user_external
  - user_shibboleth
Member

butonic commented May 19, 2017

👍 works!

➜  owncloud-9.1-10x patch -p1 < 27953.diff
patching file lib/private/App/AppManager.php
patching file lib/private/Installer.php
patching file lib/private/legacy/app.php
➜  owncloud-9.1-10x sudo -u www-data php /var/www/oc/owncloud-9.1-10x/occ upgrade 
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Turned on maintenance mode
Updating database schema
Updated database
Updating <files_pdfviewer> ...
Updated <files_pdfviewer> to 0.8.2
Updating <files_texteditor> ...
Updated <files_texteditor> to 2.2
Updating <gallery> ...
Updated <gallery> to 16.0.2
Updating <user_ldap> ...
Updated <user_ldap> to 0.9.0.1
Updating <activity> ...
Updating <dav> ...
Updated <dav> to 0.2.9
Drop old database tables

 Done
 28/28 [============================] 100%
Fix permissions so avatars can be stored again
 Done
 2/2 [============================] 100%
Move user avatars outside the homes to the new location
 Done
 1/1 [============================] 100%
Starting code integrity check...
Finished code integrity check
Update successful
Turned off maintenance mode
Reset log level
➜  owncloud-9.1-10x sudo -u www-data php /var/www/oc/owncloud-9.1-10x/occ app:list
Enabled:
  - activity: 2.3.4
  - admin_audit: 0.7
  - comments: 0.3.0
  - configreport: 0.1.1
  - dav: 0.2.9
  - enterprise_key: 0.1.0
  - federatedfilesharing: 0.3.0
  - federation: 0.1.0
  - files: 1.5.1
  - files_external: 0.7.0
  - files_pdfviewer: 0.8.2
  - files_sharing: 0.10.0
  - files_texteditor: 2.2
  - files_trashbin: 0.9.0
  - files_versions: 1.3.0
  - files_videoplayer: 0.9.8
  - firewall: 2.4.0
  - firstrunwizard: 1.1
  - gallery: 16.0.2
  - market: 0.1.0
  - notifications: 0.3.0
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - systemtags_management: 0.2.0
  - templateeditor: 0.1
  - theme-enterprise: 1.0.0
  - updatenotification: 0.2.1
  - user_ldap: 0.9.0.1
  - windows_network_drive: 0.6.0
  - workflow: 0.2.3
Disabled:
  - announcementcenter
  - encryption
  - external
  - files_antivirus
  - files_ldap_home
  - objectstore
  - password_policy
  - sharepoint
  - theme-example
  - user_external
  - user_shibboleth
@butonic

This comment has been minimized.

Show comment
Hide comment
@butonic

butonic May 19, 2017

Member

the mysql docker did not come up in jenkins

Member

butonic commented May 19, 2017

the mysql docker did not come up in jenkins

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

Rebased. COME ON, JENKINS!!!

Member

PVince81 commented May 19, 2017

Rebased. COME ON, JENKINS!!!

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

IT WAS ABOUT TIME!

Member

PVince81 commented May 19, 2017

IT WAS ABOUT TIME!

@PVince81 PVince81 merged commit 84b99d8 into master May 19, 2017

4 checks passed

Scrutinizer 2 new issues, 2 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the fix-app-version-as-stored-in-db-when-installing-via-market branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment