New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete appstoreurl config value when enabling market #27956

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 19, 2017

Description

To avoid side effects with old APIs still using it.

Related Issue

Workaround for #27951

How Has This Been Tested?

  1. Setup stable9.1.
  2. Set "appstoreenabled" to "false" in config.php
  3. Upgrade to this branch occ upgrade
  4. Check config.php and see that the value is gone
  5. Install an app with occ market:install guests and see it works

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 19, 2017

Member

another timeout... rebased

Member

PVince81 commented May 19, 2017

another timeout... rebased

@PVince81 PVince81 merged commit 2cc8475 into master May 19, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the appstoreenable-with-market branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment