New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return no user when uid is null #27965

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@VicDeo
Member

VicDeo commented May 19, 2017

Description

Do not execute SQL query when looking for user with uid NULL

Related Issue

owncloud/updater#424

Motivation and Context

oc_accounts doesn't exist in 9.1.5
While upgrading to 10.0.x we are trying to search user with uid NULL in this table

How Has This Been Tested?

  1. Install 9.1.5
  2. Override updater.server.url to point to 10.0.1rc3
  3. Do web update

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VicDeo VicDeo added this to the 10.0.2 milestone May 19, 2017

@VicDeo VicDeo requested a review from PVince81 May 19, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

Weird thing that the NULL user managed to go that far in the linked trace... 👍

Member

PVince81 commented May 22, 2017

Weird thing that the NULL user managed to go that far in the linked trace... 👍

@PVince81 PVince81 modified the milestones: 10.0.1, 10.0.2 May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

Since this breaks the web updater, merging for 10.0.1

Member

PVince81 commented May 22, 2017

Since this breaks the web updater, merging for 10.0.1

@PVince81 PVince81 merged commit c5381b8 into master May 22, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer 1 updated code elements
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the fix-updater-424 branch May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

@VicDeo please make another PR to add a unit test to enforce the null case, thanks

Member

PVince81 commented May 22, 2017

@VicDeo please make another PR to add a unit test to enforce the null case, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment