New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception after enabling app, for additional info #27970

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 22, 2017

Description

Seems it was changed from Error to Exception. We still need to throw the exception to be able to display the message.

Related Issue

None raised

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 PVince81 added this to the 10.0.1 milestone May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

Not sure why Error was changed to Exception here 394ba7d.
Any particular reason ? @DeepDiver1975

An alternative PR here would be to switch it back to "Error" but then we don't have the logging bit.

Member

PVince81 commented May 22, 2017

Not sure why Error was changed to Exception here 394ba7d.
Any particular reason ? @DeepDiver1975

An alternative PR here would be to switch it back to "Error" but then we don't have the logging bit.

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG May 22, 2017

Member

Works 👍

Member

SergioBertolinSG commented May 22, 2017

Works 👍

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

ran unit tests locally, went fine, merging to save some time (and hope for the best)

Member

PVince81 commented May 22, 2017

ran unit tests locally, went fine, merging to save some time (and hope for the best)

@PVince81 PVince81 merged commit c9e7148 into master May 22, 2017

2 of 3 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
Scrutinizer 3 new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PVince81 PVince81 deleted the enableapp-throwexception branch May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment