New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't login user after setup, doesn't work any way #27971

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@PVince81
Member

PVince81 commented May 22, 2017

Description

Remove code that automatically logs in the admin user after setting up
ownCloud. This doesn't work anyway.

Related Issue

Motivation and Context

Unneeded code triggers more app loading at setup time through the extra login, which can cause other side effects or even have the setup command look like it failed.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SergioBertolinSG @DeepDiver1975

Don't login user after setup, doesn't work any way
Remove code that automatically logs in the admin user after setting up
ownCloud. This doesn't work anyway.

@PVince81 PVince81 added this to the 10.0.1 milestone May 22, 2017

@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG May 22, 2017

Member

Works 👍

Member

SergioBertolinSG commented May 22, 2017

Works 👍

@PVince81 PVince81 merged commit 878db78 into master May 22, 2017

2 of 3 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
Scrutinizer 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PVince81 PVince81 deleted the setup-nologinafter branch May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

ran unit tests locally, went fine, merging to save some time (and hope for the best)

Member

PVince81 commented May 22, 2017

ran unit tests locally, went fine, merging to save some time (and hope for the best)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment