New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix don show shares you own in "shared with you" #27972

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
4 participants
@peterprochaska
Contributor

peterprochaska commented May 22, 2017

Description

added check for not showing shares you own

Related Issue

https://github.com/owncloud/security-tracker/issues/246

Motivation and Context

make ownCloud more secure

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@SergioBertolinSG

This comment has been minimized.

Show comment
Hide comment
@SergioBertolinSG

SergioBertolinSG May 22, 2017

Member

👍 Works.

Member

SergioBertolinSG commented May 22, 2017

👍 Works.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

Code looks good but as I see no change in unit tests I expect a failure will happen

Member

PVince81 commented May 22, 2017

Code looks good but as I see no change in unit tests I expect a failure will happen

@DeepDiver1975 DeepDiver1975 removed the request for review from rullzer May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

fantastic

...................
12:59:02 [ERROR] Waited 600 seconds, no response
12:59:02 Kill the docker aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 Makefile:179: recipe for target 'test-php' failed
12:59:02 make: *** [test-php] Error 1
[Pipeline] }

@DeepDiver1975 mind restarting the job ?

Member

PVince81 commented May 22, 2017

fantastic

...................
12:59:02 [ERROR] Waited 600 seconds, no response
12:59:02 Kill the docker aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 Makefile:179: recipe for target 'test-php' failed
12:59:02 make: *** [test-php] Error 1
[Pipeline] }

@DeepDiver1975 mind restarting the job ?

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

fantastic

...................
12:59:02 [ERROR] Waited 600 seconds, no response
12:59:02 Kill the docker aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 Makefile:179: recipe for target 'test-php' failed
12:59:02 make: *** [test-php] Error 1
[Pipeline] }

@DeepDiver1975 mind restarting the job ?

Member

PVince81 commented May 22, 2017

fantastic

...................
12:59:02 [ERROR] Waited 600 seconds, no response
12:59:02 Kill the docker aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 aaf42736f5408011fd265dd1a80f9f56eaa59db0eba9dd55047df544dd13692a
12:59:02 Makefile:179: recipe for target 'test-php' failed
12:59:02 make: *** [test-php] Error 1
[Pipeline] }

@DeepDiver1975 mind restarting the job ?

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 May 22, 2017

Member

restarted

Member

DeepDiver1975 commented May 22, 2017

restarted

@PVince81 PVince81 merged commit 83a788c into master May 22, 2017

3 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@PVince81 PVince81 deleted the dont-show-shares-you-own-in-sharedwithyou branch May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

@Peter-Prochaska don't forget to submit a separate PR to add a proper test for this

Member

PVince81 commented May 22, 2017

@Peter-Prochaska don't forget to submit a separate PR to add a proper test for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment