New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overwrite a git clone of an app with code from the marketplace #27973

Merged
merged 1 commit into from May 22, 2017

Conversation

Projects
None yet
2 participants
@DeepDiver1975
Member

DeepDiver1975 commented May 22, 2017

Description

It is very annoying when ./occ upgrade grabs an app from the marketplace and kills a local app installation.

Motivation and Context

Don't annoy developers

How Has This Been Tested?

  • grab e.g. the market app from github
  • run occ upgrade
  • see that the local clone is not killed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0.1 milestone May 22, 2017

@DeepDiver1975 DeepDiver1975 requested a review from PVince81 May 22, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 May 22, 2017

Member

Code looks good 👍

Member

PVince81 commented May 22, 2017

Code looks good 👍

@PVince81 PVince81 merged commit cb6f4a2 into master May 22, 2017

1 of 3 checks passed

continuous-integration/jenkins/pr-head This commit is being built
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Scrutinizer No new issues
Details

@PVince81 PVince81 deleted the dont-kill-app-git-clones branch May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment