Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove apps that will go to market from shipped.json #27985
Makes it possible to uninstall them.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
I don't have full understanding of the extent of the "shipped" flag. Grepping for
So grepping all of these apps to show what OCS routes they might register:
@tomneedham is checking whether it's really possible to extend/overwrite the endpoints in 10.0. Because from what I remember we removed this possibility a long time ago when unifying the APIs. (something about integrating with app framework I think)
Just checked with 10.0.1 => You can still 'extend' existing routes by registering for the same route and returning data - the responses are then 'merged'. This is done using
@tomneedham thanks. This kind of weird overriding of routes isn't officially supported. I thought we properly removed this already. Might need more work for this.
This means at this point we will remove the apps anyway from shipped.json. The likeliness of someone overwriting routes like this is anyway minimal.
Waiting for CI then merge