New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ensure that FileInfo return values as required by its phpdoc." #28649

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
4 participants
@PVince81
Member

PVince81 commented Aug 11, 2017

Reverts #27389

Fixes #28275

However we still need to investigate why sometimes a size can be a string without being on 32-bit platform and without being bigger than max int. There could be bugs somewhere else in the code.

@PVince81 PVince81 requested a review from mrow4a Aug 11, 2017

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 11, 2017

Member

the alternative proposal is a bit risky for third party apps at this stage: #28275

Member

PVince81 commented Aug 11, 2017

the alternative proposal is a bit risky for third party apps at this stage: #28275

@jvillafanez

This comment has been minimized.

Show comment
Hide comment
@jvillafanez

jvillafanez Aug 11, 2017

Member

Adding a warning at least in the getSize method might be a good idea for the time being.

Anyway, 👍

Member

jvillafanez commented Aug 11, 2017

Adding a warning at least in the getSize method might be a good idea for the time being.

Anyway, 👍

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 11, 2017

Member

stable10: #28654

Member

PVince81 commented Aug 11, 2017

stable10: #28654

@PVince81 PVince81 merged commit 76ba1ca into master Aug 11, 2017

4 checks passed

Scrutinizer No new issues
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@PVince81 PVince81 deleted the revert-27389-fix_fileinfo branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment