Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix migration issue caused during upgrade to version 10 #29049

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

sharidas
Copy link
Contributor

This change will help users to fix the migration
issue caused during upgrade to version 10. If
user had opted user specific key in the older versions
then no drop down will appear in the version 10.
Same applies if user had opted for the masterkey
in older version, no drop down will appear in version
10.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

When user tries to upgrade from versions < 10, the userSpecificKey is not present in the appConfig. And as a result during migration to version 10.0.2, the user gets an option to select the encryption mode :

  • User Specific Key
  • Master Key
    This issue is addressed with this change.

Related Issue

#28985

Motivation and Context

The change made here solves, the issues caused during migration.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sharidas sharidas self-assigned this Sep 18, 2017
@sharidas sharidas added this to the development milestone Sep 18, 2017
@PVince81
Copy link
Contributor

@sharidas please do a quick retest when coming from 10.0.3 to this branch (just one case is enough)

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if it works

@PVince81
Copy link
Contributor

@sharidas please always add a link in the original PR to the backport

@sharidas
Copy link
Contributor Author

Test result of migration from 10.0.3beta ( tarball ) to the current change:

  • Migration of 10.0.3beta with masterkey enabled to the current master change. Works well. The encryption page doesn't show drop down and here is the screenshot:
    migrationwithmasterkeyfrom10-0-3

  • Migration from 10.0.3beta from userkey enabled to the current change. Works well. The encrytion page doesnt show the drop down and here is the screenshot :
    migrationwithuserkeyfrom10-0-3

This change will help users to fix the migration
issue caused during upgrade to version 10. If
user had opted user specific key in the older versions
then no drop down will appear in the version 10.
Same applies if user had opted for the masterkey
in older version, no drop down will appear in version
10.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas merged commit 7d74b5f into stable10 Sep 29, 2017
@PVince81 PVince81 deleted the fix-migration-issue-stable10 branch October 9, 2017 08:53
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants