Raise more useful message when constructor are not resolvable #29737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever resolved class C exists but one of its constructor arguments cannot be resolved, the app framework would throw an exception that the class C does not exist even though it does. This is misleading and leads to confusion, anger and loss of time. This fix expands the error message to include the message about the constructor argument that wasn't properly forwarded.
DeepDiver1975
approved these changes
Dec 1, 2017
Codecov Report
@@ Coverage Diff @@
## master #29737 +/- ##
============================================
- Coverage 62.62% 62.62% -0.01%
- Complexity 17581 17582 +1
============================================
Files 1037 1037
Lines 57906 57908 +2
============================================
Hits 36262 36262
- Misses 21644 21646 +2
Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whenever resolved class C exists but one of its constructor arguments
cannot be resolved, the app framework would throw an exception that the
class C does not exist even though it does. This is misleading and leads
to confusion, anger and loss of time.
This fix expands the error message to include the message about the
constructor argument that wasn't properly forwarded.
Related Issue
None raised.
Motivation and Context
Happened to me several times
How Has This Been Tested?
Open settings/Application, go to the CheckSetupController and modify one letter of one of the constructor arg services. Ex replace "Config" with "Xonfig". Then go to settings page and check owncloud.log.
Before the fix: it would say that CheckSetupController does not exist at all.
After the fix. it says the above, but also adds that constructor arg "Xonfig" could not be resolved.
Screenshots (if appropriate):
Types of changes
Checklist: