Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support heic #30093

Merged
merged 2 commits into from Jan 11, 2018

Conversation

@DeepDiver1975
Copy link
Member

commented Jan 10, 2018

Description

HEIF and HEIC formats are added to iOS and will pop up in the cloud sooner or later.

Related Issue

owncloud/gallery#737

How Has This Been Tested?

  • upload a heic file and see at least it being marked as an image

get test images from here https://nokiatech.github.io/heif/examples.html

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone Jan 10, 2018

@DeepDiver1975 DeepDiver1975 self-assigned this Jan 10, 2018

@codecov

This comment has been minimized.

Copy link

commented Jan 11, 2018

Codecov Report

Merging #30093 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30093      +/-   ##
============================================
- Coverage     58.25%   58.24%   -0.01%     
- Complexity    18520    18525       +5     
============================================
  Files          1093     1094       +1     
  Lines         63712    63739      +27     
============================================
+ Hits          37113    37126      +13     
- Misses        26599    26613      +14
Impacted Files Coverage Δ Complexity Δ
drone/src/lib/private/legacy/files.php 0% <0%> (ø) 65% <0%> (+3%) ⬆️
...src/apps/files_sharing/lib/API/OCSShareWrapper.php 0% <0%> (ø) 6% <0%> (ø) ⬇️
drone/src/lib/private/PreviewManager.php 50.76% <0%> (ø) 49% <0%> (ø) ⬇️
drone/src/lib/private/Preview/Heic.php 0% <0%> (ø) 1% <0%> (?)
...rone/src/apps/files_sharing/lib/API/Share20OCS.php 91.89% <0%> (+0.26%) 150% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 412f756...40c69f7. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 2157bb2 into master Jan 11, 2018

6 of 7 checks passed

codecov/project 58.24% (-0.01%) compared to 412f756
Details
Scrutinizer 2 updated code elements
Details
codecov/patch Coverage not affected when comparing 412f756...40c69f7
Details
continuous-integration/drone/pr the build was successful
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@DeepDiver1975 DeepDiver1975 deleted the add-support-heic branch Jan 11, 2018

@DeepDiver1975

This comment has been minimized.

Copy link
Member Author

commented Jan 11, 2018

@PVince81 @butonic backport?

@PVince81
Copy link
Member

left a comment

👍

@PVince81

This comment has been minimized.

Copy link
Member

commented Jan 11, 2018

yes

@lock

This comment has been minimized.

Copy link

commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.