allow edge to gc chunks

[butonic]

Edge has a hard 5GB memory limit. currently chunked uploading seems to use one indirection too many so edge will never garbage collect the chunks Blob objects.

Unsetting them manually after a chunk is completed is not enough. The memory tab in edge won't show you the objects on the heap, but overall memory consumption will still increase.

This pr allows cs to happen by removing the actual data before passing the options to the anonymous handler: https://github.com/owncloud/core/compare/update-jqfu-fix-edge-oom?expand=1#diff-9e1e26ed9e6e26bd68c321b010edc0d9R772

The other changes stem from a bump to the latest version, which has some cool things like blueimp/jQuery-File-Upload#3486 that would allow us to use dynamic chunk sizes based on the network bandwith.

• create PR against upstream
• use proper dependency management

[butonic]

maybe this even prevents ie from freezing as well.

[butonic]

upstream PR: blueimp/jQuery-File-Upload#3508

[codecov]

Codecov Report

Merging #31825 into master will decrease coverage by 0.19%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #31825     +/-   ##
===========================================
- Coverage     63.45%   63.25%   -0.2%     
+ Complexity    18785    18457    -328     
===========================================
  Files          1158     1158             
  Lines         69718    69319    -399     
  Branches       1261     1261             
===========================================
- Hits          44237    43846    -391     
+ Misses        25111    25103      -8     
  Partials        370      370

Flag	Coverage Δ	Complexity Δ
#javascript	52.47% <ø> (-47.53%)	0 <ø> (ø)
#phpunit	64.48% <ø> (-1.53%)	18457 <ø> (-2329)

Impacted Files	Coverage Δ	Complexity Δ
apps/files_external/lib/Lib/Backend/SFTP.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files_external/lib/Lib/Backend/Swift.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files_external/lib/Lib/Backend/Local.php	76.92% <0%> (ø)	0% <0%> (ø)	⬇️
core/js/systemtags/systemtagmodel.js	85.71% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files_external/lib/Command/Export.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files_external/lib/Lib/Backend/SFTP_Key.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
...s/files_external/lib/Lib/Storage/StreamWrapper.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
core/js/sharedialoglinksocialview.js	51.72% <0%> (ø)	0% <0%> (ø)	⬇️
core/js/config.js	3.33% <0%> (ø)	0% <0%> (ø)	⬇️
core/js/octemplate.js	11.11% <0%> (ø)	0% <0%> (ø)	⬇️
... and 100 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66029f1...d472c6a. Read the comment docs.

[PVince81]

seems this PR changed approach completely? @butonic

did the new approach work ?

at least it looks much less intrusive!

[butonic]

It works for EdgeHTML 17 (the current stable version for Win 10). It does not work for EdgeHTML 15. Which is what is being used. Still an improvement. Without this Edge will eat memory the size of every upload and restart the process when 5GB have been reached. You can monitor the memory being eaten live in the dev tools memory tab. https://www.browserstack.com/test-on-microsoft-edge-browser allows you to test EdgeHTML 15 and 17 in your browser for free.

[PVince81]

We could still put this in though ?

[butonic]

Yes, should be put in. Prevents memory leak and crash when uploading large file with EdgeHTML 16 or greater.

[butonic]

backport to 10 needed

[butonic]

failing test unrelated

[phil-davis]

failing test unrelated

caldav/carddav drone jobs changed a few days ago (last week?). A rebase here will pick all that up and the jobs will pass.

[PVince81]

👍 looks safe, merging

[PVince81]

@butonic please backport

[PVince81]

stable10: #31884