Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change file name to something sensible #33381

Merged
merged 1 commit into from Nov 2, 2018
Merged

change file name to something sensible #33381

merged 1 commit into from Nov 2, 2018

Conversation

paurakhsharma
Copy link
Member

Description

Change filename from dav-versions.feature to fileVersions so that file name makes more sense regarding the tests inside.

Related issue: #33379

@paurakhsharma paurakhsharma added this to the development milestone Nov 1, 2018
@paurakhsharma paurakhsharma self-assigned this Nov 1, 2018
@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis
Copy link
Contributor

It needs something else merged to master so that rebase will do something, then CI might run again and code coverage might come.

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@codecov
Copy link

codecov bot commented Nov 1, 2018 •
edited

Codecov Report

Merging #33381 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33381   +/-   ##
=========================================
  Coverage     64.06%   64.06%           
  Complexity    18277    18277           
=========================================
  Files          1190     1190           
  Lines         69051    69051           
  Branches       1271     1271           
=========================================
  Hits          44238    44238           
  Misses        24443    24443           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (ø) 18277 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0cfd7...187b82e. Read the comment docs.

@phil-davis
Copy link
Contributor

@ownclouders rebase

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@phil-davis phil-davis merged commit 1c6ff6b into master Nov 2, 2018
@phil-davis phil-davis deleted the change-dav-versions-fileName branch November 2, 2018 04:02
@paurakhsharma paurakhsharma mentioned this pull request Nov 2, 2018
Merged
@paurakhsharma
Copy link
Member Author

Backport on: #33390

@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@paurakhsharma paurakhsharma

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paurakhsharma @phil-davis @ownclouders