-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable10] add before-after share link auth events #34399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@ownclouders rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
@ownclouders rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
90eac1c
to
a4c5d93
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #34399 +/- ##
===========================================
Coverage ? 63.48%
Complexity ? 19123
===========================================
Files ? 1264
Lines ? 75198
Branches ? 1288
===========================================
Hits ? 47743
Misses ? 27077
Partials ? 378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #34399 +/- ##
===========================================
Coverage ? 62.74%
Complexity ? 19135
===========================================
Files ? 1264
Lines ? 75236
Branches ? 1291
===========================================
Hits ? 47209
Misses ? 27647
Partials ? 380
Continue to review full report at Codecov.
|
Automated rebase with GitMate.io was successful! 🎉 |
@ownclouders rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
a4c5d93
to
30c6286
Compare
Automated rebase with GitMate.io was successful! 🎉 |
Unrelated error in git step... Rebased again to try one more time. |
Backport of #34158
Description
Adds before and after events for public share link auths.
Related Issue
The first step for:
#33542, owncloud/brute_force_protection#57
Motivation and Context
To be able to detect and interrupt public link share auth attempts.
How Has This Been Tested?
Manually and unit test
Types of changes
Checklist: