[stable10] The great CORS fix ..

[DeepDiver1975]

backport #34391

[codecov]

Codecov Report

Merging #34476 into stable10 will decrease coverage by 18.15%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             stable10   #34476       +/-   ##
===============================================
- Coverage       63.35%    45.2%   -18.16%     
===============================================
  Files            1264      116     -1148     
  Lines           75301    11482    -63819     
  Branches         1291     1291               
===============================================
- Hits            47706     5190    -42516     
+ Misses          27215     5912    -21303     
  Partials          380      380

Flag	Coverage Δ	Complexity Δ
#javascript	53.32% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	31.02% <ø> (-33.41%)	0 <ø> (-19088)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Files/Storage/DAV.php	59.45% <0%> (-21.64%)	0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1135 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4704713...31855db. Read the comment docs.

[codecov]

Codecov Report

Merging #34476 into stable10 will increase coverage by <.01%.
The diff coverage is 90.9%.

@@              Coverage Diff               @@
##             stable10   #34476      +/-   ##
==============================================
+ Coverage       63.84%   63.85%   +<.01%     
- Complexity      19105    19109       +4     
==============================================
  Files            1265     1265              
  Lines           75381    75396      +15     
  Branches         1293     1293              
==============================================
+ Hits            48127    48141      +14     
- Misses          26873    26874       +1     
  Partials          381      381

Flag	Coverage Δ	Complexity Δ
#javascript	53.29% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	64.98% <90.9%> (ø)	19109 <7> (+4)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/api.php	40.65% <0%> (-0.17%)	85 <0> (ø)
...ppFramework/Middleware/Security/CORSMiddleware.php	100% <100%> (ø)	13 <0> (+1)	⬆️
apps/dav/lib/Connector/Sabre/CorsPlugin.php	97.61% <100%> (+0.05%)	17 <0> (ø)	⬇️
lib/private/legacy/response.php	27.73% <100%> (+6.3%)	53 <7> (+3)	⬆️
ocs/routes.php	100% <100%> (ø)	0 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22896f9...df4d4e4. Read the comment docs.

[PVince81]

1) OCA\DAV\Tests\unit\Connector\Sabre\CorsPluginTest::testAuthenticatedAdditionalAllowedHeaders
Expectation failed for method name is equal to <string:getHTTPMethods> when invoked zero or more times
Parameter 0 for invocation Sabre\DAV\ServerPlugin::getHTTPMethods('') does not match expected value.
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'owncloud/remote.php/dav/files/user1/target/path'
+''

@DeepDiver1975

[DeepDiver1975]

:sacrebleu:

[DeepDiver1975]

@PVince81 test fixed ....

[PVince81]

👍

[DeepDiver1975]

Thx