Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Log exception when background job class not found #34723

Merged
merged 3 commits into from Apr 9, 2019

Conversation

@phil-davis
Copy link
Contributor

commented Mar 9, 2019

Backport #32623

@PVince81 I found this backport branch already here, but there did not seem to be a PR. So I have rebased and started this backport PR.

@phil-davis phil-davis self-assigned this Mar 9, 2019
@phil-davis phil-davis requested review from PVince81 and tomneedham Mar 9, 2019
@phil-davis phil-davis referenced this pull request Mar 9, 2019
1 of 10 tasks complete
@phil-davis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

https://drone.owncloud.com/owncloud/core/15888/92

PHPUnit 5.7.27 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.38-3+ubuntu16.04.1+deb.sury.org+1
Configuration: /drone/src/tests/phpunit-autotest.xml
Error:         No code coverage driver is available

........S....................................................   61 / 5109 (  1%)
.............................................................  122 / 5109 (  2%)
PHP Fatal error: Call to undefined method OC\BackgroundJob\JobList::listJobs() in /drone/src/tests/lib/BackgroundJob/JobListTest.php on line 268

listJobs() is added by https://github.com/owncloud/core/pull/31630/files#diff-682d0340741ed685e9e7427318d97521R329 and that PR has not yet been backported. So it seems that this backport will also be blocked.

@PVince81 @DeepDiver1975 ?

@phil-davis phil-davis force-pushed the stable10-log-job-not-found branch from 49fe540 to ba1fe47 Mar 9, 2019
@codecov

This comment has been minimized.

Copy link

commented Mar 9, 2019

Codecov Report

Merging #34723 into stable10 will increase coverage by 14.38%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           stable10   #34723       +/-   ##
=============================================
+ Coverage     30.64%   45.03%   +14.38%     
=============================================
  Files            53      116       +63     
  Lines          4160    11465     +7305     
  Branches          0     1291     +1291     
=============================================
+ Hits           1275     5163     +3888     
- Misses         2885     5923     +3038     
- Partials          0      379      +379
Flag Coverage Δ
#javascript 53.22% <ø> (?)
#phpunit 30.64% <ø> (ø) ⬆️
Impacted Files Coverage Δ
core/js/oc-dialogs.js 2.66% <0%> (ø)
core/js/oc-backbone.js 50% <0%> (ø)
settings/js/admin-apps.js 6.46% <0%> (ø)
core/js/config.js 3.33% <0%> (ø)
core/js/sharemodel.js 63.63% <0%> (ø)
core/js/files/client.js 82.84% <0%> (ø)
core/js/l10n.js 90.54% <0%> (ø)
core/js/js.js 55.05% <0%> (ø)
core/js/systemtags/systemtags.js 90% <0%> (ø)
apps/comments/js/commentcollection.js 72.72% <0%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076d734...ba1fe47. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Mar 9, 2019

Codecov Report

Merging #34723 into stable10 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34723      +/-   ##
==============================================
+ Coverage       64.27%   64.29%   +0.01%     
  Complexity      20010    20010              
==============================================
  Files            1283     1283              
  Lines           76694    76697       +3     
  Branches         1307     1307              
==============================================
+ Hits            49298    49310      +12     
+ Misses          27015    27006       -9     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.01% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.49% <100%> (+0.01%) 20010 <1> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 62.13% <ø> (ø) 174 <0> (ø) ⬇️
lib/private/Server.php 86.54% <100%> (+0.01%) 253 <0> (ø) ⬇️
lib/private/BackgroundJob/JobList.php 80.26% <100%> (+6.26%) 33 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f1b97...7a772c5. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-log-job-not-found branch from ba1fe47 to c24cdf9 Mar 18, 2019
@phil-davis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

Commit from other backport PR #34783 has been added here, because this backport is dependent on that commit getting in first/also.

So this PR is blocked because #34783 is blocked. See comment #31630 (comment)

@phil-davis phil-davis referenced this pull request Mar 30, 2019
1 of 10 tasks complete
@phil-davis phil-davis force-pushed the stable10-log-job-not-found branch from c24cdf9 to 3fc5bdd Apr 3, 2019
@phil-davis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

@PVince81 this is ready for approval after #34783 is merged.

tomneedham and others added 3 commits Sep 6, 2018
@PVince81 PVince81 force-pushed the stable10-log-job-not-found branch from 3fc5bdd to 7a772c5 Apr 9, 2019
@PVince81

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

rebased and adjusted "since" version to say 10.2.0

@PVince81 PVince81 added this to the development milestone Apr 9, 2019
@phil-davis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@PVince81 CI is green. I can't review, because it is my PR.

@phil-davis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

rebased and adjusted "since" version to say 10.2.0

"since" PHPdoc changes forward-ported to master in #34994

@PVince81 PVince81 merged commit 24b9b6d into stable10 Apr 9, 2019
5 checks passed
5 checks passed
codecov/patch 100% of diff hit (target 64.27%)
Details
codecov/project 64.29% (+0.01%) compared to 32f1b97
Details
continuous-integration/drone/pr the build was successful
Details
license/cla Contributor License Agreement is signed.
Details
security/snyk - build/package.json (owncloud) No manifest changes detected
@delete-merged-branch delete-merged-branch bot deleted the stable10-log-job-not-found branch Apr 9, 2019
@PVince81 PVince81 removed this from the development milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.